ports/68252: [PATCH] astro/celestia: point to correct full complete source tarball
Paul Seniura
pdseniura at techie.com
Wed Jun 23 19:31:32 UTC 2004
>Number: 68252
>Category: ports
>Synopsis: [PATCH] astro/celestia: point to correct full complete source tarball
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 23 19:30:18 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: "Paul Seniura" <pdseniura at techie.com>
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
State of Okla. D.O.T.
>Environment:
System: FreeBSD techpc04.okladot.state.ok.us 5.2-CURRENT FreeBSD 5.2-CURRENT #1: Wed Jun 23 10:30:07 CDT 2004 root at techpc04.okladot.state.ok.us:/usr/obj/src/sys/IBM300SY_4BSD_Os i386
>Description:
The astro/celestia port Makefile v1.17 is currently pointing
to a known incomplete source tarball. A gmake error will
eventually show up during the build:
==snip==
gmake[5]: *** No rule to make target `eclipsefinderdlg.cpp', needed by `eclipsefinderdlg.o'. Stop.
==snip==
I've documented further compile problems on the ports@
maillist here:
<http://docs.FreeBSD.org/cgi/mid.cgi?20040623155459.5873F5C9B>
>How-To-Repeat:
Use the v1.17 Makefile to try building the app.
>Fix:
Change MASTER_SITES to point to SourceForge's repositories
for Celestia. Change distinfo to correlate.
===cut-here===
--- Makefile_orig Mon Jun 21 16:54:31 2004
+++ Makefile Wed Jun 23 13:29:41 2004
@@ -8,8 +8,7 @@
PORTNAME= celestia
PORTVERSION= 1.3.1
CATEGORIES= astro
-MASTER_SITES= http://fresh.t-systems-sfr.com/unix/src/misc/
-# ${MASTER_SITE_SOURCEFORGE}
+MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= celestia
MAINTAINER= trevor at FreeBSD.org
--- distinfo_orig Mon Jun 14 00:53:39 2004
+++ distinfo Tue Jun 22 15:12:38 2004
@@ -1,2 +1,2 @@
-MD5 (celestia-1.3.1.tar.gz) = 6b5fd597e497b951228c83d4e756a340
-SIZE (celestia-1.2.4.tar.gz) = 10280646
+MD5 (celestia-1.3.1.tar.gz) = fcb73c43f5899f8f7e6d0c619a818a8b
+SIZE (celestia-1.3.1.tar.gz) = 13291363
===cut-here===
The SF sites can be quite slow, but they do have the
official tarball, and the updated distinfo matches it.
I would like to suggest we not alter the gcc optimization
parms that are set in the original project's Makefiles.
This app needs every tweak it can get. ;) To illustrate,
after applying the above Makefile patch, the patch below
will keep the original project's parms intact (I'm striving
to test this patch running -Current on a puny pentium2 box):
===cut-here===
--- Makefile Wed Jun 23 13:29:41 2004
+++ Makefile_nohack Wed Jun 23 13:59:17 2004
@@ -57,7 +57,7 @@
pre-patch:
@${REINPLACE_CMD} -e \
-'s:-O2::g; s:-Wall::g; s:-ffast-math::g; s:-fexpensive-optimizations::g; s:! /bin/sh:! ${LOCALBASE}/bin/bash:g' \
+'s:! /bin/sh:! ${LOCALBASE}/bin/bash:g' \
${WRKSRC}/configure
pre-install:
===cut-here===
We still have a remaining issue when WITH_KDE=yes is in
effect, explained further in the ports@ maillist post
mentioned above. I believe other platforms are seeing
the KDE bug, too, and will investigate further.
For now, tho, we really should change the Makefile &
distinfo to point to the correct full source tarball,
at the very least, please. :)
-- thx, Paul Seniura
System Specialist
State of Okla. D.O.T.
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list