ports/68129: [maintainer-update]; port net/gtk-gnutella update to 0.93.4
pav at FreeBSD.org
Mon Jun 21 18:00:22 UTC 2004
Synopsis: [maintainer-update]; port net/gtk-gnutella update to 0.93.4
State-Changed-When: Mon Jun 21 17:57:58 GMT 2004
Committed, with modifications.
First, your WITHOUT_NLS haven't worked at all, so I removed
it for now. You need to do more than this, at least
pass a configure argument and conditionally remove .mo files
from pkg-plist. Anyway, I think WITHOUT_NLS is not worthy here
because gtk will always ever bring gettext in.
Second, your handling of OPTIONS in ICU case was wrong.
When an option is default on, you must check for WITHOUT_option.
There are code paths when WITH[OUT]_* variables are not defined
at all, and your port should behave in conformity with defaults.
More information about the freebsd-ports-bugs