ports/61197: MPlayer uses 'md5sum' to attempt to get MD5 sums

[Christopher Nehren]

>Number:         61197
>Category:       ports
>Synopsis:       MPlayer uses 'md5sum' to attempt to get MD5 sums
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 10 23:40:12 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Christopher Nehren
>Release:        FreeBSD 5.2-RC2 i386
>Organization:
>Environment:
System: FreeBSD prophecy.dyndns.org 5.2-RC2 FreeBSD 5.2-RC2 #0: Thu Jan 8 11:55:16 EST 2004 root at prophecy.dyndns.org:/usr/src/sys/i386/compile/PROPHECY i386


	
>Description:
MPlayer uses a Linux-specific extension (the 'md5sum' program, which doesn't
exist on FreeBSD) to retrieve MD5 sums of the files that it accesses. This
patch changes the snprintf to use md5 rather than md5sum. I've tested it and
it works.
>How-To-Repeat:
Install mplayer from the ports tree.
mplayer -ao null -vo md5 file1 file2 ... filen
Observe the error output stating that md5sum isn't found.
>Fix:
Admittedly, a better fix would be to implement real MD5 checksumming in
MPlayer. But as I'm not a C coder, that's beyond my ken. The patch below fixes
the problem (at least on my machine).


diff -urN MPlayer-0.92/libvo/vo_md5.c patched.MPlayer-0.92/libvo/vo_md5.c
--- MPlayer-0.92/libvo/vo_md5.c	Mon Nov 11 10:20:26 2002
+++ patched.MPlayer-0.92/libvo/vo_md5.c	Sun Jan 11 02:30:52 2004
@@ -56,7 +56,7 @@
 
     video_out_pgm.flip_page();
 
-    snprintf (buf2, 100, "md5sum %s", vo_pgm_filename);
+    snprintf (buf2, 100, "md5 %s", vo_pgm_filename);
     f = popen (buf2, "r");
     i = fread (buf2, 1, sizeof(buf2), f);
     pclose (f);
>Release-Note:
>Audit-Trail:
>Unformatted: