ports/61123: mplayer-skins port's Makefile is incorrect

[Seva Gluschenko]

>Number:         61123
>Category:       ports
>Synopsis:       mplayer-skins port's Makefile is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 09 04:20:07 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Seva Gluschenko
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
Yandex LLC
>Environment:
System: FreeBSD road.yandex.ru 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Mon Dec 22 19:53:00 MSK 2003 root@:/local/obj/local/usr/src/sys/ROAD i386


	
>Description:
	the multimedia/mplayer-skins port stands for MPlayer's GUI. It provides
	many different skins, in totally unfriendly manner, however. First of all,
	its Makefile wants to download every skin regardless of the set of skins
	you want to set actually. Next, it contains several typos with definitions.

	Proposed patch addresses these problems.
>How-To-Repeat:
	CVSup to the latest mplayer/skins port and try to install only selected
	skins. Feel the disappointment.
>Fix:

	Apply patch below while standing in /usr/ports/multimedia/mplayer-skins:

--- Makefile.orig	Thu Jan  8 19:48:37 2004
+++ Makefile	Fri Jan  9 15:16:25 2004
@@ -14,29 +14,7 @@
 		ftp://ftp.lug.udel.edu/MPlayer/Skin/:Skin \
 		http://www.stud.uni-karlsruhe.de/~uedc/mplayer/:mini
 PKGNAMESUFFIX=	-skins
-DISTFILES=	default-1.7.tar.bz2:Skin \
-		AlienMind-1.1.tar.bz2:Skin \
-		avifile-1.5.tar.bz2:Skin \
-		BlueHeart-1.4.tar.bz2:Skin \
-		CornerMP-1.0.tar.bz2:Skin \
-		CornerMP-aqua-1.0.tar.bz2:Skin \
-		Cyrus-1.0.tar.bz2:Skin \
-		gnome-1.1.tar.bz2:Skin \
-		hayraphon-1.0.tar.bz2:Skin \
-		hwswskin-1.0.tar.bz2:Skin \
-		mentalic-1.1.tar.bz2:Skin \
-		MidnightLove-1.5.tar.bz2:Skin \
-		neutron-1.4.tar.bz2:Skin \
-		phony-1.0.tar.bz2:Skin \
-		plastic-1.1.1.tar.bz2:Skin \
-		proton-1.1.tar.bz2:Skin \
-		slim-1.0.tar.bz2:Skin \
-		trium-1.1.tar.bz2:Skin \
-		WindowsMediaPlayer6-1.2.tar.bz2:Skin \
-		xanim-1.5.tar.bz2:Skin \
-		xine-lcd-1.0.tar.bz2:Skin \
-		Orange-1.1.tar.bz2:Skin \
-		mini-0.1.tar.bz2:mini
+DISTFILES=	default-1.7.tar.bz2:Skin
 EXTRACT_ONLY=
 DIST_SUBDIR=	mplayer
 
@@ -121,90 +99,112 @@
 
 .ifdef(WITH_SKIN_ALIENMIND)
 EXTRACT_ONLY+=	AlienMind-1.1.tar.bz2
+DISTFILES+=	AlienMind-1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_AVIFILE)
 EXTRACT_ONLY+=	avifile-1.5.tar.bz2
+DISTFILES+=	avifile-1.5.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_BLUEHEART)
 EXTRACT_ONLY+=	BlueHeart-1.4.tar.bz2
+DISTFILES+=	BlueHeart-1.4.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_CORNERMP)
 EXTRACT_ONLY+=	CornerMP-1.0.tar.bz2
+DISTFILES+=	CornerMP-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_CORNERMP_AGUA)
 EXTRACT_ONLY+=	CornerMP-aqua-1.0.tar.bz2
+DISTFILES+=	CornerMP-aqua-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_CYRUS)
 EXTRACT_ONLY+=	Cyrus-1.0.tar.bz2
+DISTFILES+=	Cyrus-1.0.tar.bz2:Skin
 .endif
 
-.ifdef(WITH_SKIN_CYRUS)
+.ifdef(WITH_SKIN_GNOME)
 EXTRACT_ONLY+=	gnome-1.1.tar.bz2
+DISTFILES+=	gnome-1.1.tar.bz2:Skin
 .endif
 
-.ifdef(WITH_SKIN_CYRUS)
+.ifdef(WITH_SKIN_HAYRAPHON)
 EXTRACT_ONLY+=	hayraphon-1.0.tar.bz2
+DISTFILES+=	hayraphon-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_HWSW_SKIN)
 EXTRACT_ONLY+=	hwswskin-1.0.tar.bz2
+DISTFILES+=	hwswskin-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_MENTALIC)
 EXTRACT_ONLY+=	mentalic-1.1.tar.bz2
+DISTFILES+=	mentalic-1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_MIDNIGHTLOVE)
 EXTRACT_ONLY+=	MidnightLove-1.5.tar.bz2
+DISTFILES+=	MidnightLove-1.5.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_NEUTRON)
 EXTRACT_ONLY+=	neutron-1.4.tar.bz2
+DISTFILES+=	neutron-1.4.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_PHONY)
 EXTRACT_ONLY+=	phony-1.0.tar.bz2
+DISTFILES+=	phony-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_PLASTIC)
 EXTRACT_ONLY+=	plastic-1.1.1.tar.bz2
+DISTFILES+=	plastic-1.1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_PROTON)
 EXTRACT_ONLY+=	proton-1.1.tar.bz2
+DISTFILES+=	proton-1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_SLIM)
 EXTRACT_ONLY+=	slim-1.0.tar.bz2
+DISTFILES+=	slim-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_TRIUM)
 EXTRACT_ONLY+=	trium-1.1.tar.bz2
+DISTFILES+=	trium-1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_WINDOWSMEDIAPLAYER6)
 EXTRACT_ONLY+=	WindowsMediaPlayer6-1.2.tar.bz2
+DISTFILES+=	WindowsMediaPlayer6-1.2.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_XANIM)
 EXTRACT_ONLY+=	xanim-1.5.tar.bz2
+DISTFILES+=	xanim-1.5.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_XINE_LCD)
 EXTRACT_ONLY+=	xine-lcd-1.0.tar.bz2
+DISTFILES+=	xine-lcd-1.0.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_ORANGE)
 EXTRACT_ONLY+=	Orange-1.1.tar.bz2
+DISTFILES+=	Orange-1.1.tar.bz2:Skin
 .endif
 
 .ifdef(WITH_SKIN_MINI)
 EXTRACT_ONLY+=	mini-0.1.tar.bz2
+DISTFILES+=	mini-0.1.tar.bz2:Skin
 .endif
 
 pre-install:


>Release-Note:
>Audit-Trail:
>Unformatted: