ports/59496: New Port: x11/gtk-smooth-engine

[Anish Mistry]

The following reply was made to PR ports/59496; it has been noted by GNATS.

From: Anish Mistry <amistry at am-productions.biz>
To: Joe Marcus Clarke <marcus at marcuscom.com>,
	Jeremy Messenger <mezz7 at cox.net>
Cc: freebsd-gnats-submit at FreeBSD.org, edwin at FreeBSD.org
Subject: Re: ports/59496: New Port: x11/gtk-smooth-engine
Date: Sat, 3 Jan 2004 18:16:36 -0500

 --Boundary-00=_V109/AaScRyZqlb
 Content-Type: text/plain;
   charset="iso-8859-1"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Saturday 03 January 2004 15:23, Joe Marcus Clarke wrote:
 > On Sat, 2004-01-03 at 13:23, Jeremy Messenger wrote:
 > > This one does really need to clean, so here's my feedback.
 > >
 > > 	- The CATEGORIES needs to be change to 'x11-toolkits gnome',
 > > 	  just check 'ls /usr/ports/x11-toolkits | grep gtk' to see how many
 > > 	  gtk themes are in there. Which meaning, you should move this
 > > 	  port from x11 to x11-toolkits.
 > >
 > > 	- Need to add the 'CONFLICT= gnome-themes-extras-*',
 > > 	  because the x11-toolkits/gnome-themes-extras has the smooth
 > > 	  engine in there.
 >
 > Or just remove this port entirely since we already have the Smooth
 > engine in the tree.
 >
 > Joe
 I've attached a patch that I think fixes most of the feedback.  I didn't know 
 how to have it moved correctly to the x11-toolkits directory with diff.
 
 -- 
 Anish Mistry
 amistry at am-productions.biz
 AM Productions
 --Boundary-00=_V109/AaScRyZqlb
 Content-Type: text/x-diff;
   charset="iso-8859-1";
   name="gtk-smooth-engine.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename="gtk-smooth-engine.patch"
 
 diff -ruN gtk-smooth-engine.orig/Makefile gtk-smooth-engine/Makefile
 --- gtk-smooth-engine.orig/Makefile	Sat Jan  3 05:38:43 2004
 +++ gtk-smooth-engine/Makefile	Sat Jan  3 17:36:39 2004
 @@ -6,39 +6,42 @@
  
  PORTNAME=	gtk-smooth-engine
  PORTVERSION=	0.5.6
 -CATEGORIES=	x11
 +CATEGORIES=	x11-toolkits gnome
  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
  MASTER_SITE_SUBDIR=	smooth-engine
  
  MAINTAINER=	amistry at am-productions.biz
  COMMENT=	Flexible GTK Theme Engine
  
 -.if exists(${X11BASE}/lib/libgtk-x11-2.0.so.200)
 +USE_X_PREFIX=	yes
 +USE_LIBTOOL=	yes
 +INSTALLS_SHLIB=	yes
 +SHLIB_VERSION=	0
 +CONFLICT=	gnome-themes-extras-*
 +WANT_GNOME=	yes
 +
 +.include <bsd.port.pre.mk>
 +
 +.if ${HAVE_GNOME:Mgtk20}!=""
  WITH_GTK2=	yes
  .endif
  
 -.if exists(${X11BASE}/lib/libgtk12.so.2)
 +.if ${HAVE_GNOME:Mgtk12}!=""
  WITH_GTK12=	yes
  .endif
  
 -.if defined(WITH_GTK12)
 -LIB_DEPENDS+=	gtk12.2:${PORTSDIR}/x11-toolkits/gtk12
 -.endif
 -
  # if neither gtk is detected automatically pull in gtk2
  .if !defined(WITH_GTK12) && !defined(WITH_GTK2)
  WITH_GTK2=	yes
  .endif
  
  .if defined(WITH_GTK2)
 -LIB_DEPENDS+=	gtk-x11-2.0:${PORTSDIR}/x11-toolkits/gtk20
 +USE_GNOME+=	gtk20
  .endif
  
 -USE_X_PREFIX=	yes
 -USE_LIBTOOL=	yes
 -USE_GNOME=	gtk12 gtk20
 -INSTALLS_SHLIB=	yes
 -SHLIB_VERSION=	0
 +.if defined(WITH_GTK12)
 +USE_GNOME+=	gtk12
 +.endif
  
  pre-everything::
  .if !defined(WITH_GTK2)
 @@ -54,4 +57,4 @@
  	@${LN} -sf libsmooth.so \
  		${X11BASE}/lib/gtk-2.0/2.2.0/engines/libsmooth.so.${SHLIB_VERSION}
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 diff -ruN gtk-smooth-engine.orig/pkg-plist gtk-smooth-engine/pkg-plist
 --- gtk-smooth-engine.orig/pkg-plist	Sat Jan  3 05:38:43 2004
 +++ gtk-smooth-engine/pkg-plist	Sat Jan  3 17:10:44 2004
 @@ -1,4 +1,3 @@
  lib/gtk-2.0/2.2.0/engines/libsmooth.so
  lib/gtk-2.0/2.2.0/engines/libsmooth.so.0
  lib/gtk-2.0/2.2.0/engines/libsmooth.la
 - at dirrm lib/gtk-2.0/2.2.0/engines
 
 --Boundary-00=_V109/AaScRyZqlb--