ports/63545: Today's portupgrade of linux-flashplugin to FreeBSD-4.9Stable

[Joe Marcus Clarke]

On Sun, 2004-02-29 at 18:09, Joe Marcus Clarke wrote:
> On Sun, 2004-02-29 at 18:00, Brandon D. Valentine wrote:
> > The following reply was made to PR ports/63545; it has been noted by GNATS.
> > 
> > From: "Brandon D. Valentine" <ports at brandon.dvalentine.com>
> > To: Jeremy Messenger <mezz7 at cox.net>
> > Cc: freebsd-gnats-submit at FreeBSD.org, stacey at vickiandstacey.com
> > Subject: Re: ports/63545: Today's portupgrade of linux-flashplugin to linux-flashplugin-6.0r79_1 breaks flash for linux-opera on FreeBSD-4.9Stable
> > Date: Sun, 29 Feb 2004 16:50:54 -0600
> > 
> >  On Sun, Feb 29, 2004 at 04:34:26PM -0600, Jeremy Messenger wrote:
> >  > Actually, you can't do the define PLUGINSDIR because there's no "?" in it.
> >  > 
> >  > PLUGINSDIR?=
> >  
> >  Hmm, you're right.  I will include that change in the patch I am working
> >  on.
> >  
> >  The problem I'm running into is I don't seem to get variable expansion
> >  to work inside my conditional.
> >  
> >  This works:
> >  
> >  .for f in ${LIBFILES}
> >      @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> >  .if exists(/usr/local/lib/linux-mozilla/plugins)
> >  	echo "Hi! I'm inside the if statement!"
> >      @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> >  ${PREFIX}/${PLUGINSDIR}
> >  .endif
> >  .endfor
> >  
> >  This doesn't:
> >  
> >  .for f in ${LIBFILES}
> >      @${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/lib/linux-flashplugin6
> >  .if exists(${PREFIX}/${PLUGINSDIR})
> >  	echo "Hi! I'm inside the if statement!"
> >      @${LN} -sf ${PREFIX}/lib/linux-flashplugin6/${f}
> >  ${PREFIX}/${PLUGINSDIR}
> >  .endif
> >  .endfor
> >  
> >  And I'm not sure why it doesn't work.  At any rate, I have a solution
> >  and with a bit more testing I'll submit a new patch.
> 
> Convert this make conditional into a shell script conditional, and it
> will work:
> 
> 	@for f in ${LIBFILES}; do \
> 		${INSTALL_DATA} ${WRKSRC}/$${f} \ 			${PREFIX}/lib/linux-flashplugin6;
> \
> 		if [ -d ${PREFIX}/${PLUGINSDIR} ]; then \
> 			echo "Hi! I'm inside the if statement!"; \
> 			${LN} -sf \ 				${PREFIX}/lib/linux-flashplugin6/$${f}; \
> 		fi; \
> 	done
> 
> You never want to use exists on a directory anyway.

I forgot to add, you will want to also do:

.include <bsd.port.pre.mk>

Before your targets so that variable expansion works as expected.

Joe

> 
> Joe
> 
> >  
> >  Sorry for the inconvenience,
> >  
> >  Brandon D. Valentine
> >  -- 
> >  brandon at dvalentine.com                           http://www.geekpunk.net
> >  Pseudo-Random Googlism:  tejas is mccarley's way of continuing his
> >                           family's texas traditions
> > _______________________________________________
> > freebsd-ports-bugs at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe at freebsd.org"
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20040229/8d2b798d/attachment.sig>