ports/63059: linux-flashplugin LATEST_LINK and RESTRICTED fixes
Oliver Eikemeier
eikemeier at fillmore-labs.com
Fri Feb 27 22:00:41 UTC 2004
The following reply was made to PR ports/63059; it has been noted by GNATS.
From: Oliver Eikemeier <eikemeier at fillmore-labs.com>
To: "Brandon D. Valentine" <brandon at dvalentine.com>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: ports/63059: linux-flashplugin LATEST_LINK and RESTRICTED fixes
Date: Fri, 27 Feb 2004 22:51:02 +0100
Brandon D. Valentine wrote:
> On Thu, Feb 26, 2004 at 01:31:36AM +0100, Oliver Eikemeier wrote:
>
>>Ok, I understand what should be done here. May I make two suggestions:
>
> Thanks for reviewing this, Oliver.
You are welcome. Thanks for your explanations.
>>- it would be nice to have the link creation in a pkg-install script,
>> since the autodetection fails if the port is installed from a package
>
> The port sets NO_PACKAGE and RESTRICTED. Do I still need to worry about
> pkg-install time? =)
Maybe. Users might decide to build packages locally (eg to update multiple
machines, like a lab).
>>- a more-or-less short comment what would be removed and why wouldn't be
>>bad,
>> (especially because this may remove symlinks not created by the port).
>> I'm not sure where to place this comments, though. Perhaps the pkg-install
>> script where the links are created is a good place.
>
> I'm not sure where the best place to put this is either. Should I just
> put a comment in the Makefile or do I need to print a warning to the
> user at install time?
No, I guess users aren't really interested. It's more stupid committers asking
the same stupid questions over & over again.
Maybe you want to include some of this in the next revision.
Oliver
More information about the freebsd-ports-bugs
mailing list