ports/63389: lang/php4 doesn't read PHP4_OPTIONS from Makefile.local anymore

[Osma Suominen]

>Number:         63389
>Category:       ports
>Synopsis:       lang/php4 doesn't read PHP4_OPTIONS from Makefile.local anymore
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 26 05:40:08 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Osma Suominen
>Release:        FreeBSD 4.8-RC i386
>Organization:
Coop Sange
>Environment:
System: FreeBSD oiva.sange.fi 4.8-RC FreeBSD 4.8-RC #2: Thu Mar 6 19:04:51 EET 2003 root at oiva.sange.fi:/fs/syst/usr/obj/fs/syst/usr/src/sys/OIVA i386
>Description:
lang/php4 Makefile allows options to be read from various places instead
of having to set them on each install, which is good. I had placed my
options in /usr/ports/lang/php4/Makefile.local

However, it seems the mega-patch for PR 57699 (Makefile CVS rev 1.30) moved
the inclusion of bsd.port.pre.mk down. This means that Makefile.local is now
included only after options have been chosen, so setting PHP4_OPTIONS there
has no effect.

I know there are other ways of specifying PHP options. For me, a magic
php4_options file is not very intuitive; a Makefile.local in the expected
place is much better.

>How-To-Repeat:

cd /usr/ports/lang/php4

Create a file Makefile.local and specify some options there:

--clip--
PHP4_OPTIONS= MYSQL IMAP
--clip--

Run make

The default options are used instead of the ones specified in Makefile.local

>Fix:

Solution 1:
Move the inclusion of bsd.port.pre.mk back above the options stuff. This
will probably break things that were reported in PR 57699 (OpenLDAP, MySQL)
and fixed in Makefile 1.30. Maybe there are other ways to fix those?

Solution 2:
Hard-code the inclusion of Makefile.local (and Makefile.inc, while you're at
it) so it is done before determining options. Not very pretty but does the
job I believe.

Solution 3:
Decide that writing options in Makefile.local (and/or .inc) is not a
supported way of selecting options, and document it in the beginning of the
Makefile.
>Release-Note:
>Audit-Trail:
>Unformatted: