ports/75289: menu creation borked in dvdauthor, bad ImageMagick interaction

[Andy Sparrow]

>Number:         75289
>Category:       ports
>Synopsis:       menu creation borked in dvdauthor, bad ImageMagick interaction
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 20 08:00:51 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Andy Sparrow
>Release:        FreeBSD 4.11-PRERELEASE i386
>Organization:
Not Much
>Environment:
System: FreeBSD tureg.geek4food.org 4.11-PRERELEASE FreeBSD 4.11-PRERELEASE #147: Thu Dec 16 00:56:46 PST 2004 root at tureg.geek4food.org:/usr/src/sys/compile/tureg i386

	dvdauthor-0.6.10_2
	ImageMagick-6.1.6.6

System cvsup'd Dec 14th or thereabout, all ports portupgrade'd after.

>Description:

	DVD Menu creation (spumux) is borked on the above combination
	of packages (current ports as of this report). No buttons
	are detected, the mask file is detected as one giant button
	(jumppad still works).

	According to this post on a GenToo forum:

	http://forums.gentoo.org/viewtopic.php?t=117709&postdays=0&postorder=asc&start=200&sid=25f5ea21c8a84bf33c3fc0301ddfba05

	the index used to indicate transparency in ImageMagick has
	changed for versions >= ~6.0.7

	However, the last release of dvdauthor doesn't seem to know
	this, possibly it pre-dates it.

	The last two alphas of dvdauthor don't compile, it was
	easiest to fix this problem than sift through the broken
	autocruft^Wautoconf.

>How-To-Repeat:

	Follow any functional tutorial to create a DVD menu. spumux
	will detect the entire mask file as a single button:

spumux spu.xml < main_menu.mpg > final.mpg
DVDAuthor::spumux, version 0.6.10.
Build options: gnugetopt magick iconv freetype
Send bugs to <dvdauthor-users at lists.sourceforge.net>

INFO: Locale=C
INFO: Converting filenames to US-ASCII
INFO: Picture had 2 colors
INFO: Picture had 2 colors
INFO: Constructing blank img
INFO: Autodetect 0 = 0x0-720x576
INFO: Pickbuttongroups, success with 1 groups, useimg=1
WARN:  Read 0, expected 4
INFO: Found EOF in .sub file.
INFO: Max_sub_size=1966
INFO: 1 subtitles added, 0 subtitles skipped, stream: 32, offset: 0.18

Statistics:
- Processed 0 subtitles.
- The longest display line had -1 characters.
- The maximum number of displayed lines was 0.
- The normal display height of the font arial.ttf was 0.
- The bottom display height of the font arial.ttf was 0.
- The biggest subtitle box had 1966 bytes.

	With the patch applied, the output looks rather different
	and DVD menu buttons are functional:

/tmp/spumux spu.xml < main_menu.mpg > final.mpg
DVDAuthor::spumux, version 0.6.10.
Build options: gnugetopt magick iconv freetype
Send bugs to <dvdauthor-users at lists.sourceforge.net>

INFO: Locale=C
INFO: Converting filenames to US-ASCII
INFO: Picture had 2 colors
INFO: Picture had 2 colors
INFO: Constructing blank img
INFO: Autodetect 0 = 38x44-97x78
INFO: Autodetect 1 = 37x94-189x128
INFO: Autodetect 2 = 37x141-352x181
INFO: Autodetect 3 = 40x192-207x230
INFO: Pickbuttongroups, success with 1 groups, useimg=1
WARN:  Read 0, expected 4
INFO: Found EOF in .sub file.
INFO: Max_sub_size=722
INFO: 1 subtitles added, 0 subtitles skipped, stream: 32, offset: 0.18

Statistics:
- Processed 0 subtitles.
- The longest display line had -1 characters.
- The maximum number of displayed lines was 0.
- The normal display height of the font arial.ttf was 0.
- The bottom display height of the font arial.ttf was 0.
- The biggest subtitle box had 722 bytes.


>Fix:

	Drop this into /usr/ports/multimedia/dvdauthor/files as
	patch-subgen-image.c:

--- src/subgen-image.c.orig     Sun Dec 19 22:38:27 2004
+++ src/subgen-image.c  Sun Dec 19 22:38:44 2004
@@ -177,7 +177,7 @@
             p.r=pdata[x*4];
             p.g=pdata[x*4+1];
             p.b=pdata[x*4+2];
-            p.t=255-pdata[x*4+3];
+            p.t=pdata[x*4+3];
             putpixel(s,y*s->width+x,&p);
         }
     }



>Release-Note:
>Audit-Trail:
>Unformatted: