ports/75262: [PATCH] www/firefox: error running firefox -v

[Palle Girgensohn]

>Number:         75262
>Category:       ports
>Synopsis:       [PATCH] www/firefox: error running firefox -v
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 19 17:00:50 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Palle Girgensohn
>Release:        FreeBSD 5.3-RELEASE-p1 i386
>Organization:
Ping Pong AB
>Environment:
System: FreeBSD palle.girgensohn.se 5.3-RELEASE-p1 FreeBSD 5.3-RELEASE-p1 #16: Sat Nov 20 04:26:58 CET 2004
>Description:

when running firefox -v, an error is generated. This confuses for
example firefox-remote, so there's always an error whenn running
it. This is especially annoying when using a GUI emailer - clicking a
URL in an email always give an error dialouge.

Port maintainer (gnome at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:

$ /usr/X11R6/bin/firefox -V
expr: illegal option -- V
usage: expr [-e] expression
[: -eq: unexpected operator
Mozilla Firefox 1.0, Copyright (c) 2004 mozilla.org

>Fix:

The check only searchs for the string ':/', so an extra prefix X will
not disturb it:


--- firefox-1.0_5,1.patch begins here ---
Index: files/patch-browser_app_mozilla.in
===================================================================
RCS file: /home/ncvs/ports/www/firefox/files/patch-browser_app_mozilla.in,v
retrieving revision 1.3
diff -u -u -r1.3 patch-browser_app_mozilla.in
--- files/patch-browser_app_mozilla.in	20 Nov 2004 20:24:36 -0000	1.3
+++ files/patch-browser_app_mozilla.in	19 Dec 2004 16:45:40 -0000
@@ -1,5 +1,5 @@
---- browser/app/mozilla.in.orig	Sat Nov 13 00:54:51 2004
-+++ browser/app/mozilla.in	Sat Nov 13 00:57:22 2004
+--- browser/app/mozilla.in.orig	Tue Oct 26 11:26:11 2004
++++ browser/app/mozilla.in	Sun Dec 19 17:44:44 2004
 @@ -110,6 +110,7 @@
    # Check default compile-time libdir
    if [ -x "$moz_libdir/run-mozilla.sh" ]; then
@@ -8,7 +8,16 @@
    else 
      echo "Cannot find mozilla runtime directory. Exiting."
      exit 1
-@@ -207,12 +207,31 @@
+@@ -160,7 +161,7 @@
+ 	_optLast="${i}"
+ done #last arg
+ 
+-if [ `expr "${_optLast}" : '.*:/.*'` -eq 0 -a \( -f "${_optLast}" -o -d "${_optLast}" \) ]; then
++if [ `expr X"${_optLast}" : '.*:/.*'` -eq 0 -a \( -f "${_optLast}" -o -d "${_optLast}" \) ]; then
+ 	# Last argument seems to be a local file/directory
+ 	# Check, if it is absolutely specified (ie. /home/foo/file vs. ./file)
+ 	# If it is just "relatively" (./file) specified, make it absolutely
+@@ -207,12 +208,31 @@
        script_args="$script_args -d $2"
        shift 2
        ;;
--- firefox-1.0_5,1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: