ports/71111: [PATCH] games/wesnoth: update to 0.8.3

mezz7 at cox.net mezz7 at cox.net
Mon Aug 30 03:34:36 UTC 2004


> From: Ulrich Spoerlein <q at uni.de>
> 
> On Sun, 29.08.2004 at 16:01:59 -0400, mezz7 at cox.net wrote:
> > I will have to agree with pav here about looks very ugly. I don't
> > approve this patch, but I shall take some good parts from this patch
> > after ports tree freeze in my new patch. Sorry, it will not make it
> > before ports tree freeze. However, the reason I don't approve this
> > patch is remove pkg-plist, force gcc 3.3 and etc.
> 
> USE_GCC is only needed for -STABLE because it doesn't compile with gcc
> 2.95 and I am unable to fix this C++ crap...

Well you see, it will not need the USE_GCC if I can fix it. At the almost each version, I had to fix it to get it works nicely with the GCC 2.9x. I can't make a fix before ports freeze, I don't have any FreeBSD desktop anymore because my motherboard has died. New computer will be arrive between Monday to Wednesday. The truth is that I rather to wait after ports tree freeze to update Wesnoth.

> It probably looks ugly, because it creates the PLIST, installs all files
> and then adds all the directories to the PLIST. Half of it could be
> avoided, if a plain 'make install' wouldn't overflow the argument list.

I don't see how the pkg-plist has to do with the 'make install''s overflow to install Wesnoth, however.

> Anyway, I talked to the wesnoth people and they'll probably fix this by
> using some secret incantation of find(1) to install these files (wargus'
> Makefiles are a mess...)
> 
> I'd rather go for an automated pkg-plist creation, because there will
> always be new scenarios and campaigns added to wesnoth, which will add
> considerably churn to the CVS. The pkg-plist is 1849 lines right now....

Sorry, I am very strongly disagree with the automated pkg-plist because I depend on pkg-plist a lot to find what file(s) that are belong to port to create dependency or whatever. I like to find stuff in pkg-plist than google, because it's a lot quickly and know which port. I can't see how the pkg-plist will hurt you when you just do the 'make install'. However, have the pkg-plist helps me to track the files better too. I don't need to list the full reasons here.

Cheers,
Mezz

> Ulrich Spoerlein



More information about the freebsd-ports-bugs mailing list