ports/70286: [update] www/suphp: Makefile error - can't compile object files

[Jeremy Chadwick]

The following reply was made to PR ports/70286; it has been noted by GNATS.

From: Jeremy Chadwick <freebsd at jdc.parodius.com>
To: Volker Stolz <vs at freebsd.org>
Cc: freebsd-gnats-submit at freebsd.org, paul+fbsd at it.ca
Subject: Re: ports/70286: [update] www/suphp: Makefile error - can't compile object files
Date: Wed, 11 Aug 2004 22:16:26 -0700

 I have examined the PR, and initially responded with a statement
 that said PR 70286 was correct.  However, I was wrong in making
 this statement.
 
 PR 70286 should be closed, as it's incorrect.  We do not need to
 change ${OBJS} to ${SRCS}.  The line in question links all of the .o
 files files together to make the suphp binary for Apache.  The .o files
 are compiled via directives at the very end of src/Makefile; ${OBJS}
 relies on ${SRCS}, and calls $(CC) on each .c file in ${SRCS}.
 
 It would make more sense to use `ld' to link the .o files together
 and make a binary.  However, this opens up a HUGE new can of worms:
 we'd have to link to libc (-lc), which sounds great, but isn't: Apache
 can be threaded, and therefore on those systems it should be linked
 with -lpthreads or -lc_r (deprecated).  The original suphp Makefile
 and configure framework doesn't check for this, which is something to
 take up with the original suphp author.  This might explain some of
 the "weirdness" going on with people using suphp with Apache 2.x who
 don't use the prefork MPM.  As I said though, that's a whole different
 can of worms...
 
 Also in addition, please close PR #69662 -- I will be submitting a
 brand new and fresh PR in a few minutes that will provide everything
 necessary (including a proper unified diff for everything).
 
 Thanks!
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |
 
 On Wed, Aug 11, 2004 at 03:15:54PM +0200, Volker Stolz wrote:
 > Dear maintainer, please take the following PR into account.
 > 
 > Volker