ports/70242: [PATCH] sixxs-heartbeatd cores sometimes

[Meno Abels]

>Number:         70242
>Category:       ports
>Synopsis:       [PATCH] sixxs-heartbeatd cores sometimes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 10 06:30:24 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Meno Abels
>Release:        FreeBSD 5.2.1-RELEASE-p9 i386
>Organization:
adviser com
>Environment:
System: FreeBSD race 5.2.1-RELEASE-p9 FreeBSD 5.2.1-RELEASE-p9 #14: Sun Jul 4 09:10:57 CEST 2004 root at neo.abels.adviser.com:/usr/obj/usr/src/sys/GENERIC i386

>Description:
	The return value of getaddrinfo is only check on negative but freebsd
        return positiv values also to indicate a problem.
>How-To-Repeat:
	Have a dsl line and wait.
>Fix:
	PATCH to sixxs-heartbeatd port

diff --new-file -ur sixxs-heartbeatd.org/Makefile sixxs-heartbeatd/Makefile
--- sixxs-heartbeatd.org/Makefile	Sat May 15 06:03:40 2004
+++ sixxs-heartbeatd/Makefile	Tue Aug 10 08:14:54 2004
@@ -7,7 +7,7 @@
 
 PORTNAME=	sixxs-heartbeatd
 PORTVERSION=	20031026
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.sixxs.net/archive/sixxs/heartbeat/unix/
 DISTNAME=	heartbeat-unix-2003-10-26
diff --new-file -ur sixxs-heartbeatd.org/files/patch-client_heartbeat-hb.c sixxs-heartbeatd/files/patch-client_heartbeat-hb.c
--- sixxs-heartbeatd.org/files/patch-client_heartbeat-hb.c	Thu Jan  1 01:00:00 1970
+++ sixxs-heartbeatd/files/patch-client_heartbeat-hb.c	Tue Aug 10 08:14:08 2004
@@ -0,0 +1,23 @@
+
+$FreeBSD$
+
+--- client/hb.c.orig	Tue Aug 10 08:10:03 2004
++++ client/hb.c	Tue Aug 10 08:09:11 2004
+@@ -91,7 +91,7 @@
+ 	hints.ai_socktype = SOCK_DGRAM;
+ 
+ 	// Get the POP IPv4 into a sockaddr
+-	if (getaddrinfo(sIPv4POP, PORT, &hints, &res) < 0)
++	if (getaddrinfo(sIPv4POP, PORT, &hints, &res) != 0)
+ 	{
+ 		hblog(LOG_ERR, "Couldn't resolve POP ip %s\n", sIPv4POP);
+ 		close(sockfd);
+@@ -147,7 +147,7 @@
+ 		hints.ai_socktype = SOCK_DGRAM;
+ 		
+ 		// Get the POP IPv4 into a sockaddr
+-		if (getaddrinfo(sIPv4LocalResolve, NULL, &hints, &res) < 0)
++		if (getaddrinfo(sIPv4LocalResolve, NULL, &hints, &res) != 0)
+ 		{
+ 			hblog(LOG_ERR, "Couldn't resolve POP ip %s\n", sIPv4POP);
+ 			// We return a -1, thus the app will keep beating

>Release-Note:
>Audit-Trail:
>Unformatted: