ports/69885: [patch] unbreak xmbmon for gcc 3.4.2

Alexander Marx mad at madness.at
Sun Aug 1 21:30:25 UTC 2004


>Number:         69885
>Category:       ports
>Synopsis:       [patch] unbreak xmbmon for gcc 3.4.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 01 21:30:24 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Marx
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD cube.madness.at 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Sat Jul 31 01:35:04 CEST 2004     root at cube.madness.at:/usr/src/sys/i386/compile/CUBE1  i386


	
>Description:
	xmbmon port fails to compile on -current with gcc 3.4.2
	
>How-To-Repeat:
	on a system with gcc 3.4.2

	cd /usr/ports/sysutils/xmbmon
	make

	the compile then stops with

	cc -O -pipe   -I. -DHAVE_CONFIG_H -Wall -s -o testsmb testsmb.c pci_pm.o smbuses.o smbus_piix4.o smbus_amd.o smbus_ali.o smbus_amd8.o 
	testsmb.c: In function `main':
	testsmb.c:146: error: label at end of compound statement
	*** Error code 1
	
	Stop in /usr/ports/sysutils/xmbmon/work/xmbmon204.
	*** Error code 1
	
	Stop in /usr/ports/sysutils/xmbmon.

	
>Fix:
	the following small patch seems to fix this; verified to build/run on
	5.2-CURRENT (as of Jul 31) and 4.10-STABLE (from Jul 17).

--- testsmb.c.orig      Sun Aug  1 22:51:49 2004
+++ testsmb.c   Sun Aug  1 22:55:12 2004
@@ -126,7 +126,7 @@
                break;
        default:
                fprintf(stderr, "No known SMBus(I2C) chip found.\n");
-               goto exit;
+               continue;
        }
 
        if(OpenIO() == -1) return -1;
@@ -141,7 +141,6 @@
        }
 
        CloseIO();
-exit:
 
   } /* endo of Big roop for smb_base candidates */
   exit (0);

	


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list