ports/65291: samba-devel default installation is broken on FreeBSD 4.x

[Michael Nottebrock]

>Number:         65291
>Category:       ports
>Synopsis:       samba-devel default installation is broken on FreeBSD 4.x
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 07 07:40:15 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Michael Nottebrock
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD kiste 4.9-STABLE FreeBSD 4.9-STABLE #1: Tue Mar 23 22:34:26 CET 2004 lofi at kiste:/usr/obj/usr/src/sys/KISTE i386


	
>Description:

Kerberos detection fails on 4.x. The port Makefile reads the output of krb5-config
into a variable but does not check if the krb5-config actually or if the returned
string isn't empty. Thus, it never depends on security/heimdal in FreeBSD 4.x, causing
the default port installation to fail during configure stage.

Below is a fix, please review. 
>How-To-Repeat:
	
>Fix:

	

--- samba-devel.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/samba-devel/Makefile,v
retrieving revision 1.114
diff -u -r1.114 Makefile
--- Makefile	6 Apr 2004 11:56:20 -0000	1.114
+++ Makefile	7 Apr 2004 14:19:32 -0000
@@ -197,7 +197,7 @@
 .if defined(WANT_KRB5)
 # Relay on PATH
 KRB5_PREFIX!=		krb5-config --prefix
-.if defined(KRB5_PREFIX)
+.if defined(KRB5_PREFIX) && !empty (KRB5_PREFIX)
 CONFIGURE_ARGS+=	--with-krb5=${KRB5_PREFIX}
 .elif defined(KRB5_HOME) && exists(${KRB5_HOME}/lib/libgssapi_krb5.a)
 CONFIGURE_ARGS+=	--with-krb5=${KRB5_HOME}
--- samba-devel.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: