ports/56512: x11amp bus error

[Mário Freitas]

>Number:         56512
>Category:       ports
>Synopsis:       x11amp bus error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 05 19:00:24 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Mário Freitas
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD suzy.unbreakable.homeunix.org 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Thu Sep 4 07:52:28 WEST 2003 root at suzy.unbreakable.homeunix.org:/usr/obj/usr/src/sys/SUZY i386


	
>Description:
I've noticed x11amp just core dumps when calling a non-existent function
when you click the "x"(close) button.
You should open x11amp, queue one or more files in the playlist and then
close it.
I include 3 patches, 1 for this issue and 2 are because of gcc33.

>How-To-Repeat:

Open x11amp, queue some files in the playlist, click on the "x" button.

>Fix:

Place these three patches in the audio/x11amp/files dir.

--- patch-x11amp::main.c begins here ---
--- x11amp/main.c.orig	Tue Sep  2 03:19:22 2003
+++ x11amp/main.c	Tue Sep  2 03:19:33 2003
@@ -812,8 +812,8 @@
 	cleanup_ctrlsocket();
 	cleanup_skins();
 	playlist_stop_get_info_thread();
-	cleanup_plugins();
 	playlist_clear();
+	cleanup_plugins();
 	gtk_main_quit();
 }
 
--- patch-x11amp::main.c ends here ---

--- patch-General::ir::about.c begins here ---
--- General/ir/about.c.orig	Tue Sep  2 02:20:46 2003
+++ General/ir/about.c	Tue Sep  2 02:21:03 2003
@@ -34,9 +34,7 @@
 	gtk_container_border_width(GTK_CONTAINER(frame),5);
 	gtk_box_pack_start(GTK_BOX(vbox),frame,FALSE,FALSE,0);
 
-	label=gtk_label_new("\nCreated by Charles Sielski <stray at teklabs.net>\n
-			 Control X11amp with your TV/VCR/Stereo remote \n
-			IRman page - http://www.evation.com/irman/\n");
+	label=gtk_label_new("\nCreated by Charles Sielski <stray at teklabs.net>\nControl X11amp with your TV/VCR/Stereo remote \nIRman page - http://www.evation.com/irman/\n");
 	
 	gtk_container_add(GTK_CONTAINER(frame),label);
 
--- patch-General::ir::about.c ends here ---

--- patch-Effect::voice::about.c begins here ---
--- Effect/voice/about.c.orig	Tue Sep  2 02:16:41 2003
+++ Effect/voice/about.c	Tue Sep  2 02:17:09 2003
@@ -31,10 +31,7 @@
 	dialog=gtk_dialog_new();
 	gtk_window_set_title(GTK_WINDOW(dialog),"About Voice Removal Plugin 0.9");
 	gtk_container_border_width(GTK_CONTAINER(dialog),5);
-	label=gtk_label_new("X11AMP Voice Removal Plugin 0.9\n
-A simple voice removal plugin by 
-Anders Carlsson <anders.carlsson at tordata.se>"
-);
+	label=gtk_label_new("X11AMP Voice Removal Plugin 0.9\nA simple voice removal plugin by Anders Carlsson <anders.carlsson at tordata.se>");
 	gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox),label,TRUE,TRUE,0);
       	gtk_widget_show(label);
 	
--- patch-Effect::voice::about.c ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: