ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error

[Foxfair Hu]

The following reply was made to PR ports/56163; it has been noted by GNATS.

From: Foxfair Hu <foxfair at drago.fomokka.net>
To: Lars Thegler <lars at thegler.dk>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
Date: Tue, 2 Sep 2003 18:07:20 +0800

 --Fba/0zbH8Xs+Fj9o
 Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw"
 Content-Disposition: inline
 
 
 --wac7ysb48OaltWcw
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Sep 02, 2003 at 11:34:48AM +0200, Lars Thegler wrote:
 >=20
 > I agree - much neater.
 >=20
 > But if you add "CONFIGURE_ARGS+=3D DIR=3D'Enhanced'", won't you have to f=
 ix the
 > pkg-plist as well?
 >=20
 
   Ah, my bad. Forgot the pkgplsit one. Here is my full patch in the end
 of this email.
 
 > >I'll create a slave port for XML::SimpleObject::LibXML separately:
 >=20
 > I noticed that the author has made a separate module for
 > XML::SimpleObject::LibXML. Maybe you should port that, instead of making =
 it
 > a slave of this port.
 >=20
 
   Actually XML::SimpleObject::LibXML is included in XML::SimpleObject.
 And they use the same package file in CPAN. You can see a LibXML/ sub=20
 directory after you extract it.
 
 >=20
 > By the way, is the PORTREVISION bump really needed? Exisisting installati=
 ons
 > will work anyway, won't they? Or is this to force bento to upgrade?
 >=20
 > /Lars
 
   IMHO yes, I use PORTREVISION change to indicate a functional update of
 Makefile in ports build environment. Otherwise we have to talk about the
 rev number in CVS, too painful to me. :)
 
   Since there will be a pkg-plist change too, so bump PORTREVISION
 is also needed.
 
 foxfair
 
 
 --wac7ysb48OaltWcw
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch.p5-XML-SimpleObject"
 Content-Transfer-Encoding: quoted-printable
 
 diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/Makefile ./Makefile
 --- /usr/ports/textproc/p5-XML-SimpleObject/Makefile	Mon Aug 25 17:34:15 20=
 03
 +++ ./Makefile	Tue Sep  2 17:52:55 2003
 @@ -7,19 +7,21 @@
 =20
  PORTNAME=3D	XML-SimpleObject
  PORTVERSION=3D	0.53
 +PORTREVISION=3D	1
  CATEGORIES=3D	textproc perl5
  MASTER_SITES=3D	${MASTER_SITE_PERL_CPAN}
  MASTER_SITE_SUBDIR=3D	XML
  PKGNAMEPREFIX=3D	p5-
 =20
 -WRKSRC?=3D	${WRKDIR}/${PORTNAME}${PORTVERSION}
 -
  MAINTAINER=3D	ports at FreeBSD.org
  COMMENT=3D	API for accessing the structure of an XML document
 =20
 -BUILD_DEPENDS=3D	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}=
 /XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser
 +BUILD_DEPENDS=3D	${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textp=
 roc/p5-XML-Parser
 +
 +WRKSRC?=3D        ${WRKDIR}/${PORTNAME}${PORTVERSION}
 =20
  PERL_CONFIGURE=3D	YES
 +CONFIGURE_ARGS+=3D	DIR=3D'Enhanced'
 =20
  MAN3=3D		XML::SimpleObject.3
  MANPREFIX=3D	${PREFIX}/lib/perl5/${PERL_VERSION}
 diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/pkg-plist ./pkg-plist
 --- /usr/ports/textproc/p5-XML-SimpleObject/pkg-plist	Mon Aug 25 17:34:15 2=
 003
 +++ ./pkg-plist	Tue Sep  2 17:51:29 2003
 @@ -1,6 +1,8 @@
  %%SITE_PERL%%/%%PERL_ARCH%%/auto/XML/SimpleObject/.packlist
  %%SITE_PERL%%/XML/SimpleObject.pm
 +%%SITE_PERL%%/XML/SimpleObject/Enhanced.pm
  %%SITE_PERL%%/XML/ex.pl
 + at dirrm %%SITE_PERL%%/XML/SimpleObject
  @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/XML/SimpleObject
  @unexec rmdir %D/%%SITE_PERL%%/%%PERL_ARCH%%/auto/XML 2>/dev/null || true
  @unexec rmdir %D/%%SITE_PERL%%/XML 2>/dev/null || true
 
 --wac7ysb48OaltWcw--
 
 --Fba/0zbH8Xs+Fj9o
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.3 (FreeBSD)
 
 iD8DBQE/VGvY1VNL1U6bylkRAuBgAJ44q9Oz/GCP6jkXsSeJSRL23RXHnwCgjSTN
 NibhCm5BIOGDBHh2Z5XM/cc=
 =wpxN
 -----END PGP SIGNATURE-----
 
 --Fba/0zbH8Xs+Fj9o--