ports/58630: silently drop messages in noattach (change request)

[Luigi Rizzo]

>Number:         58630
>Category:       ports
>Synopsis:       silently drop messages in noattach (change request)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 28 06:00:27 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Luigi Rizzo
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
Dip.Ing.Informazione - univ.pisa
>Environment:
System: FreeBSD xorpc.icir.org 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Mon Apr 7 20:59:56 PDT 2003 root at xorpc.icir.org:/usr/src/sys/compile/ICIR-4.8-USB i386


>Description:
noattach will send a REJECT for messages it does not want to
deal with. But the vast majority of these virus-generated
messages contain a fake sender address, so the reject will
cause an additional bounced email, or even worse a backfire
towards the unlucky owner of the fake address.

I have been in both categories with the recent Sobig.F
virus, receiving between 60 and 80000 (yes no typo, eighty
thousand) messages per day, and it is no fun.

I believe it is a lot safer to silently drop unwanted
messages rather than bouncing them.

The attached patch does it.

>How-To-Repeat:
	
>Fix:

	


--- noattach.c.orig	Thu Aug 21 13:52:48 2003
+++ noattach.c	Tue Oct 28 13:37:49 2003
@@ -651,7 +651,11 @@
 			safe_free(lines[i]);
 		    safe_free(lines);
 		    (void)mlfi_cleanup(ctx, true);
+#if 0
 		    return SMFIS_REJECT;
+#else
+		    return SMFIS_DISCARD;
+#endif
 		}
 		else if (cl_err == -1) {
 		    /* can't accept this message right now */
>Release-Note:
>Audit-Trail:
>Unformatted: