ports/58459: ports/net/ztelnet build problem

[David Israelsson]

>Number:         58459
>Category:       ports
>Synopsis:       ports/net/ztelnet build problem
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 23 11:50:10 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     David Israelsson
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD dipsy.gnapp.org 5.1-CURRENT FreeBSD 5.1-CURRENT #2: Thu Oct 23 19:35:12 CEST 2003 root at dipsy.gnapp.org:/usr/obj/usr/src/sys/DIPSY i386


>Description:
ztelnet won't build with gcc33
>How-To-Repeat:
>Fix:
diff -ru work.old/ztelnet/telnet/commands.c work/ztelnet/telnet/commands.c
--- work.old/ztelnet/telnet/commands.c	Thu Oct 23 12:08:27 2003
+++ work/ztelnet/telnet/commands.c	Thu Oct 23 13:20:56 2003
@@ -40,7 +40,7 @@
 #include <netdb.h>
 #include <ctype.h>
 #include <pwd.h>
-#include <varargs.h>
+#include <stdarg.h>
 #include <errno.h>
 
 #include <arpa/telnet.h>
@@ -79,8 +79,6 @@
 extern char **genget();
 extern int Ambiguous();
 
-static call();
-
 typedef struct {
 	char	*name;		/* command name */
 	char	*help;		/* help string (NULL for no help) */
@@ -2572,18 +2570,14 @@
  */
 
     /*VARARGS1*/
-    static
-call(va_alist)
-    va_dcl
+typedef int (*intrtn_t)();
+static call(intrtn_t routine, ...)
 {
     va_list ap;
-    typedef int (*intrtn_t)();
-    intrtn_t routine;
     char *args[100];
     int argno = 0;
 
-    va_start(ap);
-    routine = (va_arg(ap, intrtn_t));
+    va_start(ap, routine);
     while ((args[argno++] = va_arg(ap, char *)) != 0) {
 	;
     }

>Release-Note:
>Audit-Trail:
>Unformatted: