ports/58408: subversion makefile doesn't set correct repository permissions

[George Hartzell]

>Number:         58408
>Category:       ports
>Synopsis:       subversion makefile doesn't set correct repository permissions
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 22 22:00:35 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     George Hartzell
>Release:        FreeBSD 4.8-RELEASE-p7 i386
>Organization:
none
>Environment:
System: FreeBSD rosebud.alerce.com 4.8-RELEASE-p7 FreeBSD 4.8-RELEASE-p7 #15: Mon Sep 29 20:48:22 PDT 2003 root at rosebud.alerce.com:/usr/obj/usr/src/sys/ROSEBUD i386

>Description:
	The subversion Makefile can create a repository if 
	WITH_REPOSITORY_CREATION is set.  It is careful to set
	the correct groups and permissions on the necessary
	files, but misses one (the /dav directory).  (this only
	applies if you're running svn under apache)
>How-To-Repeat:
	Install the port with WITH_REPOSITORY_CREATION set, and
	see if the http access method works.
>Fix:

*** Makefile	2003/10/22 21:26:38	1.2
--- Makefile	2003/10/23 02:32:59
***************
*** 171,176 ****
  	@${MKDIR} ${SVNREPOS}
  	@${PREFIX}/bin/svnadmin create ${SVNREPOS}
! 	@${CHGRP} ${SVNGROUP} ${SVNREPOS}/db ${SVNREPOS}/locks/db.lock
! 	@${CHMOD} g+w ${SVNREPOS}/db ${SVNREPOS}/locks/db.lock
  	@for i in ${SVNREPOS}/db/* ; do \
  	    i=$${i##*/}; \
--- 171,176 ----
  	@${MKDIR} ${SVNREPOS}
  	@${PREFIX}/bin/svnadmin create ${SVNREPOS}
! 	@${CHGRP} ${SVNGROUP} ${SVNREPOS}/db ${SVNREPOS}/locks/db.lock ${SVNREPOS}/dav
! 	@${CHMOD} g+w ${SVNREPOS}/db ${SVNREPOS}/locks/db.lock ${SVNREPOS}/dav
  	@for i in ${SVNREPOS}/db/* ; do \
  	    i=$${i##*/}; \
>Release-Note:
>Audit-Trail:
>Unformatted: