ports/54860: Multiple problems in port misc/linux-opengroupware

[Oliver Eikemeier]

The following reply was made to PR ports/54860; it has been noted by GNATS.

From: Oliver Eikemeier <eikemeier at fillmore-labs.com>
To: Stefan Esser <se at FreeBSD.org>
Cc: Frank Reppin <frank.reppin at boerde.de>,
	freebsd-gnats-submit at FreeBSD.org
Subject: Re: ports/54860: Multiple problems in port misc/linux-opengroupware
Date: Wed, 22 Oct 2003 04:18:42 +0200

 Stefan Esser wrote:
 
 > Synopsis: new port (linux-opengroupware)
 > 
 > Port committed based on an updated submission by originator of this PR.
 
 Followup to PR 54860, cited from
   http://www.freebsd.org/cgi/cvsweb.cgi/ports/misc/linux-opengroupware/Makefile?rev=1.2
 
 > FETCH_DEPENDS=	${LOCALBASE}/sbin/apxs:${PORTSDIR}/www/apache2 \
 > 		${LOCALBASE}/bin/psql:${PORTSDIR}/databases/postgresql72 \
 > 		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash2 \
 > 		${LINUXBASE}/lib/libc-2.3.2.so:${PORTSDIR}/emulators/linux_base-8 \
 > 		${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake
 > 
 
 Not really. RUN_DEPENDS maybe?
 
 > MAKEFILE=	${WRKSRC}/opengroupware.org-mod_ngobjweb/GNUmakefile
 > BUILD_WRKSRC?=	${WRKSRC}/opengroupware.org-mod_ngobjweb
 MAKEFILE=	GNUmakefile
 should be fine.
 
 > CONFLICTS=	${PORTSDIR}/www/apache2 \
 > 		${PORTSDIR}/databases/postgresql7
 > 
 CONFLICTS matches package names, not origins. And do you depend on apache2 or
 conflict with it?
 
 > NO_PACKAGE=	We dont really build anything ...
 Why? That's not a real reason to build no package.
 
 > PLIST=		${WRKDIR}/pkg-plist
 If you could provide a static plist, which would make conflict checking possible. It
 shouldn't be that difficult, provided the hardcoded version numbers you use in SET1,
 SET2 and SET3 above.
 
 > MD5_FILE=	${MASTERDIR}/distinfo.${MACHINE_ARCH}
 Why?
 
 > PREFIX=		${LINUXBASE}
 You should use 
 USE_LINUX_PREFIX=	yes
 
 > pre-install:
 > 	${RM} -f ${PLIST}
 > 	cd ${WRKSRC} && ${FIND} -s . -type f -o -type l | \
 > 		${CUT} -c3-999 >> ${PLIST} \
 > 		&& ${FIND} -d * -type d | ${SED} -e 's:^:@dirrm :' >> ${PLIST}
 > 
 See above.
 
 > do-install:
 > ...
 > 	${FIND} ${PREFIX} -type d \! -ipath '${LINUXBASE}/proc*' -exec ${CHMOD} 755 \{\} \;
 Not all of these are your directories.
 
 > post-install:
 > 	@${MKDIR} ${LINUXBASE}/opt/opengroupware.org/documents
 > 	@${MKDIR} ${LINUXBASE}/opt/opengroupware.org/news
 > ...
 > 	@${INSTALL} -m 500 -o root -g wheel ${FILESDIR}/ogo.sh.sample ${LOCALBASE}/etc/rc.d/ogo.sh.sample
 > 	@${INSTALL} -m 500 -o root -g wheel ${FILESDIR}/zidestore.sh.sample ${LOCALBASE}/etc/rc.d/zidestore.sh.sample
 > ...
 You should install *only* to ${PREFIX}
 
 > 	@${LN} -sf ${LINUXBASE}/usr/lib/libpq.so.2 ${LINUXBASE}/usr/lib/libpq.so.3
 It look like at least this link will no show up in your dynamically generated packing list.
 Please try to provide a static one.
 
 > 	@${ECHO} '/opt/skyrix/system/Libraries/ix86/linux-gnu/gnu-fd-nil' >>${LINUXBASE}/etc/ld.so.conf
 You want to use ${ECHO_CMD} here
 
 > 	@${PERL} ${SCRIPTDIR}/patch_apache_version.pl
 and your system may not have perl installed (use USE_PERL5_BUILD)
 
 > 	@fmt ${PKGMESSAGE}
 direct use of command name