ports/59362: [patch] add new Makevar DEPRECATED to bsd.port.mk

[Mark Linimon]

>Number:         59362
>Category:       ports
>Synopsis:       [patch] add new Makevar DEPRECATED to bsd.port.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 16 22:10:20 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Mark Linimon
>Release:        FreeBSD 4.9-PRERELEASE i386
>Organization:
Lonesome Dove Computing Services
>Environment:
System: FreeBSD lonesome.lonesome.com 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #0: Fri Sep 5 01:19:33 CDT 2003 linimon at lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA_DEBUG i386
>Description:
	Currently there is no mechanism in FreeBSD (other than use of
	the mailing lists) to note the a port has outlived its usefulness.
	As with any other software, the ports have a finite lifetime.

	This functionality adds the ability to discourage users from
	installing obsolete or broken software.  It piggybacks on the
	current mechanism for BROKEN in bsd.port.mk.  If the new Makevar
	DEPRECATED is defined, and the port is not already marked BROKEN,
	then the string will be displayed to the user and installation will
	halt.  It is, of course, always possible for the user to override
	this.  In precedence, DEPRECATED would follow FORBIDDEN and BROKEN
	but precede IGNORE.

	Note: if this Makevar were added, my ports monitoring code could
	easily have a report added to it to show only ports marked DEPRECATED.
>How-To-Repeat:
	(n/a)
>Fix:
	The following diff includes the proposed changes to bsd.port.mk,
	together with 3 examples from the ports collection that I already
	have PRs filed against stating that they are obsolete.

--- /usr/ports/Mk/bsd.port.mk.dist	Fri Nov  7 21:22:08 2003
+++ Mk/bsd.port.mk	Sun Nov 16 23:18:46 2003
@@ -137,7 +137,7 @@
 # NO_PACKAGE	- Port should not be packaged for ftp sites or CDROMs,
 #				  but distfiles can be put on ftp sites and CDROMs.
 # FORBIDDEN		- Package build should not be attempted because of
-#				  security vulnerabilities.
+#				  security vulnerabilities.  (Implies IGNORE).
 # IGNORE		- Package build should be skipped entirely (e.g.
 #				  because of serious unfixable problems in the build,
 #				  because it cannot be manually fetched, etc).  Error
@@ -146,6 +146,12 @@
 # BROKEN		- Port is believed to be broken.  Package builds will
 #				  still be attempted on the bento package cluster to
 #				  test this assumption.
+# DEPRECATED	- Port installation is discouraged, either due to the fact
+# 				  it has been marked broken for some time and/or the mastersites
+#				  have all disappeared and/or support has been discontinued in
+#				  favor of some newer software.  The value should contain a
+#				  date at which the port is scheduled to be deleted if no one
+#				  fixes it in the meantime.  (Implies IGNORE).
 #
 # In addition to RESTRICTED or NO_CDROM, if only a subset of distfiles
 # or patchfiles have redistribution restrictions, set the following
@@ -2648,6 +2691,8 @@
 .endif
 .elif defined(FORBIDDEN)
 IGNORE=	"is forbidden: ${FORBIDDEN}"
+.elif defined(DEPRECATED)
+IGNORE=	"is deprecated: ${DEPRECATED}"
 .endif
 
 .if (defined(MANUAL_PACKAGE_BUILD) && defined(PACKAGE_BUILDING) && !defined(PARALLEL_PACKAGE_BUILD))
--- /usr/ports/math/simpack/Makefile	Tue Nov 11 21:13:44 2003
+++ math/simpack/Makefile	Sun Nov 16 23:38:07 2003
@@ -14,7 +14,8 @@
 MAINTAINER=	ports at FreeBSD.org
 COMMENT=	SimPack & Sim++ libraries and tools for simulatiom modelling
 
-BROKEN=		"Does not install on 4.x, does not compile on 5.x; will be removed after Feb 2"
+BROKEN=		"Does not install on 4.x, does not compile on 5.x"
+DEPRECATED=	"Obsoleted by its authors and replaced by OOPM; will be removed Feb 2, 2003"
 
 BUILD_DEPENDS=	imake:${PORTSDIR}/devel/imake-4
 
--- /usr/ports/www/netraider/Makefile	Mon Mar 10 17:00:41 2003
+++ www/netraider/Makefile	Sun Nov 16 23:46:13 2003
@@ -24,6 +24,15 @@
 CFLAGS+=	-DBSD
 SUBST=		${WRKSRC}/konq-embed/src/Makefile.in
 
+.include <bsd.port.pre.mk>
+
+ONLY_FOR_ARCHS=	i386
+
+.if ${OSVERSION} >= 500000
+BROKEN=		will not compile on FreeBSD ${OSVERSION}
+.endif
+DEPRECATED=	distfile 3 years old, mastersite gone, will be removed in December 2003
+
 pre-configure:
 	${FIND} ${WRKSRC} -name Makefile.am | ${XARGS} ${REINPLACE_CMD} -e \
 		"s at -lqt@-lqt @g; s@ -lqt @ -lqt2 at g"
@@ -35,4 +44,4 @@
 		-e 's, -lqt , -lqt2,g' \
 		${WRKSRC}/konq-embed/src/Makefile.in
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- /usr/ports/security/whisker/Makefile	Thu Oct  9 23:09:02 2003
+++ security/whisker/Makefile	Sun Nov 16 23:48:23 2003
@@ -18,6 +18,8 @@
 WRKSRC=		${WRKDIR}/v${PORTVERSION}
 NO_BUILD=	yes
 
+DEPRECATED=	Authors say to use security/nikto instead, will be deleted in December 2003
+
 do-install:
 		${INSTALL_SCRIPT} ${WRKSRC}/whisker.pl ${PREFIX}/bin/whisker
 		${MKDIR} ${PREFIX}/share/whisker
>Release-Note:
>Audit-Trail:
>Unformatted: