ports/59032: [PATCH] x11-wm/fvwm2-devel crashes b/c it is built without iconv support

[Guido Berhoerster]

>Number:         59032
>Category:       ports
>Synopsis:       [PATCH] x11-wm/fvwm2-devel crashes b/c it is built without iconv support
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 07 02:10:15 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Guido Berhoerster
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hal.privat.lan 4.9-RELEASE FreeBSD 4.9-RELEASE #0: Wed Nov 5 14:25:38 CET 2003 root at hal.privat.lan:/usr/obj/usr/src/sys/HAL i386


	
>Description:
If fvwm-2.5.8 is built without iconv support it can coredump when
opening menus. For a detailed problem description see the thread at
the fvwm-workers mailing list:
http://www.hpc.uh.edu/fvwm/archive/0311/msg00049.html .
The port does not correctly point configure to the place where iconv
is installed and is thus always built without iconv support.
	
>How-To-Repeat:
cd /usr/ports/x11-wm/fvwm2-devel && make install

A sample configuration which can be used to reproduce the crash is
provided by the post to the fvwm-workers mailing list mentioned
above.
	
>Fix:

Point configure to /usr/local/lib where iconv is installed and make
iconv support mandatory by applying the following patch:
	

--- Makefile.diff begins here ---
--- Makefile.orig	Tue Nov  4 08:03:53 2003
+++ Makefile	Fri Nov  7 10:40:09 2003
@@ -21,7 +21,8 @@
 MAINTAINER=	cy at FreeBSD.org
 COMMENT=	Popular virtual window manager for X
 
-LIB_DEPENDS=	Xft.2:${PORTSDIR}/x11-fonts/Xft
+LIB_DEPENDS=	Xft.2:${PORTSDIR}/x11-fonts/Xft \
+		biconv.2:${PORTSDIR}/converters/iconv
 RUN_DEPENDS=	gm4:${PORTSDIR}/devel/m4
 
 .if defined(WITH_STROKE)
@@ -39,6 +40,8 @@
 
 GNU_CONFIGURE=	yes
 CONFIGURE_ENV=	X_CFLAGS=-I${LOCALBASE}/include
+CONFIGURE_ARGS=	--with-iconv-library=/usr/local/lib \
+		--with-iconv-includes=/usr/local/include
 
 .if defined(WITH_STROKE)
 CONFIGURE_ARGS+=	--with-stroke --with-stroke-library=${LOCALBASE}/lib \
@@ -57,12 +60,6 @@
 LIB_DEPENDS+=	png.5:${PORTSDIR}/graphics/png
 CONFIGURE_ARGS+=	--with-png --with-png-includes=${LOCALBASE}/include \
 			--with-png-library=${LOCALBASE}/lib
-.endif
-
-.if !defined(WITHOUT_ICONV)
-LIB_DEPENDS+=	biconv.2:${PORTSDIR}/converters/iconv
-CONFIGURE_ARGS+=	--with-iconv-lib=/usr/local/lib \
-			--with-iconv-includes=/usr/local/include
 .endif
 
 .if defined(WITHOUT_BIDI)
--- Makefile.diff ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: