ports/52434: cvsd overwrites etc/cvsd/cvsd.conf without permission

[Frank Altpeter]

>Number:         52434
>Category:       ports
>Synopsis:       cvsd overwrites etc/cvsd/cvsd.conf without permission
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 19 08:40:08 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Frank Altpeter
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD murphy.planlos.de 4.8-STABLE FreeBSD 4.8-STABLE #0: Fri May 16 14:40:24 CEST 2003 root at murphy.planlos.de:/usr/obj/usr/src/sys/kernconf.murphy i386


	
>Description:
	When updating the cvsd port, it does overwrite the cvsd
	configuration file in etc/cvsd/cvsd.conf without permission.

	This seems to be because the port doesn't rely on a
	cvsd.conf.sample like it's the usual way to place configuration
	files, but does write directly to the main configuration.
>How-To-Repeat:
	root at murphy:/usr/local/etc/cvsd 0# md5 cvsd.conf
	MD5 (cvsd.conf) = 85c6bd38d7e75dad92a605cf29bed870
	murphy:/usr/local/etc/cvsd 0# vi cvsd.conf
	root at murphy:/usr/local/etc/cvsd 0# md5 cvsd.conf
	MD5 (cvsd.conf) = e98810ac3cc5521d3daf50a5a5f52858
	murphy:/usr/local/etc/cvsd 0# cd
	murphy:~ 0# portupgrade -f cvsd
	murphy:~ 0# cd -
	root at murphy:/usr/local/etc/cvsd 0# md5 cvsd.conf 
	MD5 (cvsd.conf) = 85c6bd38d7e75dad92a605cf29bed870

	As you can see, modified cvsd.conf is getting killed and
	modifications are lost.

>Fix:

	Add "s|cvsd.conf|cvsd.conf.sample|g" to the REINPLACE_CMD
	in post-patch target within the ports Makefile.



P.S. This bug has already been reported to the maintainer long time ago,
but it seems to be lost or ignored.


>Release-Note:
>Audit-Trail:
>Unformatted: