ports/51815: [NEW PORT] devel/libdjbdns: Public domain DNS client library

Sergei Kolobov sergei at kolobov.com
Sun May 11 22:51:36 UTC 2003


On 2003-05-10 at 07:48 -0500, Pete Fritchman wrote:
> What do you think about installing the includes to
> ${PREFIX}/include/djbdns?  Their names are pretty general, conflict with
> some system includes, and already conflict with another port (bglibs).

I have envisioned resolving conflicts by allowing user to override
LIBDJBDNS_ROOT variable (defaulting to PREFIX), but your suggestion
makes more sense and avoids violating POLA.

One minor change, though - IMHO, the port should install its include files
into ${PREFIX}/include/libdjbdns, so a) it has clearer connection to 
the port's name and b) avoids any possible confusion regarding whether
those files are installed by devel/libdjbdns or net/djbdns ports.

Here is the diff from the original shar:
(corresponding followup to ports/51814 will be submitted shortly)

diff -ruN libdjbdns.orig/Makefile libdjbdns/Makefile
--- libdjbdns.orig/Makefile	Mon May 12 02:35:04 2003
+++ libdjbdns/Makefile	Mon May 12 02:37:26 2003
@@ -18,8 +18,6 @@
 USE_GMAKE=	yes
 ALL_TARGET=	it
 
-LIBDJBDNS_ROOT?=	${PREFIX}
-
 LIBS=		libdjbdns.a libdjbdns.so.1
 INCLUDES=	alloc.h byte.h case.h dns.h env.h error.h fmt.h \
 		gen_alloc.h gen_allocdefs.h iopause.h ip4.h ndelay.h \
@@ -28,8 +26,9 @@
 		uint32.h uint64.h
 
 do-install:
+	@${MKDIR} ${PREFIX}/include/libdjbdns
 	cd ${WRKSRC} && \
-		${INSTALL_DATA} ${LIBS} ${LIBDJBDNS_ROOT}/lib && \
-		${INSTALL_DATA} ${INCLUDES} ${LIBDJBDNS_ROOT}/include
+		${INSTALL_DATA} ${LIBS} ${PREFIX}/lib && \
+		${INSTALL_DATA} ${INCLUDES} ${PREFIX}/include/libdjbdns
 
 .include <bsd.port.mk>
diff -ruN libdjbdns.orig/pkg-plist libdjbdns/pkg-plist
--- libdjbdns.orig/pkg-plist	Mon May 12 02:35:04 2003
+++ libdjbdns/pkg-plist	Mon May 12 02:36:28 2003
@@ -1,27 +1,27 @@
-include/alloc.h
-include/byte.h
-include/case.h
-include/dns.h
-include/env.h
-include/error.h
-include/fmt.h
-include/gen_alloc.h
-include/gen_allocdefs.h
-include/iopause.h
-include/ip4.h
-include/ndelay.h
-include/open.h
-include/openreadclose.h
-include/readclose.h
-include/scan.h
-include/select.h
-include/socket.h
-include/str.h
-include/stralloc.h
-include/tai.h
-include/taia.h
-include/uint16.h
-include/uint32.h
-include/uint64.h
+include/libdjbdns/alloc.h
+include/libdjbdns/byte.h
+include/libdjbdns/case.h
+include/libdjbdns/dns.h
+include/libdjbdns/env.h
+include/libdjbdns/error.h
+include/libdjbdns/fmt.h
+include/libdjbdns/gen_alloc.h
+include/libdjbdns/gen_allocdefs.h
+include/libdjbdns/iopause.h
+include/libdjbdns/ip4.h
+include/libdjbdns/ndelay.h
+include/libdjbdns/open.h
+include/libdjbdns/openreadclose.h
+include/libdjbdns/readclose.h
+include/libdjbdns/scan.h
+include/libdjbdns/select.h
+include/libdjbdns/socket.h
+include/libdjbdns/str.h
+include/libdjbdns/stralloc.h
+include/libdjbdns/tai.h
+include/libdjbdns/taia.h
+include/libdjbdns/uint16.h
+include/libdjbdns/uint32.h
+include/libdjbdns/uint64.h
 lib/libdjbdns.a
 lib/libdjbdns.so.1



More information about the freebsd-ports-bugs mailing list