ports/53474: Fix sound support for squeak3, and some modified.

Ceri Davies ceri at FreeBSD.org
Fri Jun 20 18:10:14 UTC 2003


The following reply was made to PR ports/53474; it has been noted by GNATS.

From: Ceri Davies <ceri at FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit at FreeBSD.org>
Cc:  
Subject: Re: ports/53474: Fix sound support for squeak3, and some modified.
Date: Fri, 20 Jun 2003 19:04:21 +0100

 Adding to audit trail, from misfiled PR ports/53551:
 
 Date: Fri, 20 Jun 2003 15:38:15 +0200
 From: Roland Jesse <roland.jesse at gmx.net>
 Message-Id: <200306201538.15619.roland.jesse at gmx.net>
 References: <20030619.095324.846931882.nin at polka.mail.plala.or.jp>
 
  Hi,
  
  On Thursday 19 June 2003 02:53, NINOMIYA Hideyuki wrote:
  > Sound support comes to do squeak3(squeak-3.5) porting, but does not
  > become effective
  
  Thanks for looking into this.
  
  A couple minor notes:
  
  * We should add "PORTREVISION=1" in case the suggested changes get committed.
  
  > -CONFIGURE_ARGS+=	--libdir=${PREFIX}/share --with-audio
  > +CONFIGURE_ARGS+=	--libdir=${PREFIX}/share --with-audio=nas
  
  It is probably better to leave out the "--with-audio" switch here completely 
  as it is already taken care of:
  
  > +.ifdef (WITHOUT_AUDIO)
  > +CONFIGURE_ARGS+=	--without-audio
  > +.else
  > +LIB_DEPENDS+=	audio.2:${PORTSDIR}/audio/nas
  > +CONFIGURE_ARGS+=	--with-audio=nas
  > +.endif
  
  This looks very nice to me.
  
  > +--- platforms/unix/config/inisqueak.in.orig	Mon Jun 16 11:14:41 2003
  > ++++ platforms/unix/config/inisqueak.in	Mon Jun 16 11:19:18 2003
  
  I don't see the need to add a new patch file to CVS. Two ${REINPLACE_CMD} 
  lines can handle this job directly from within the Makefile.
  
  Otherwise, I am all in favour of committing this fix.
  
  Best,
    Roland (maintainer of lang/squeak3)
  



More information about the freebsd-ports-bugs mailing list