ports/55134: XFree86 4.3.x failed to render underline text using true type font

[Ariff Abdullah]

>Number:         55134
>Category:       ports
>Synopsis:       XFree86 4.3.x failed to render underline text using true type font
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 31 14:20:09 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Ariff Abdullah
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
MyBSD
>Environment:
System: FreeBSD 4.x + XFree86 4.3.x


>Description:
	XFree86 4.3.0 failed to render underline text if the text rendered
	using True Type font (freetype/xtt backend).
>How-To-Repeat:
	Open mozilla / firebird , set the font to any ttf, surf
	anywhere. Notice that the links dont have underline, although
	we explicitly set 'Underline links' in mozilla/firebird
	preferences.
>Fix:
Patch to xc/lib/font/FreeType/ftfuns.c

--- lib/font/FreeType/ftfuncs.c~	2003-02-13 06:01:45.000000000 +0300
+++ lib/font/FreeType/ftfuncs.c	2003-03-04 20:27:16.000000000 +0300
@@ -959,11 +959,11 @@
         int underlinePosition, underlineThickness;
 
         if(post) {
-            underlinePosition = TRANSFORM_FUNITS_Y(post->underlinePosition);
+            underlinePosition = TRANSFORM_FUNITS_Y(-post->underlinePosition);
             underlineThickness = TRANSFORM_FUNITS_Y(post->underlineThickness);
         } else {
             underlinePosition = 
-                TRANSFORM_FUNITS_Y(t1info->underline_position);
+                TRANSFORM_FUNITS_Y(-t1info->underline_position);
             underlineThickness = 
                 TRANSFORM_FUNITS_Y(t1info->underline_thickness);
         }



>Release-Note:
>Audit-Trail:
>Unformatted: