ports/54485: [Patch] x11/xstroke Makefile error

[Matthew Seaman]

>Number:         54485
>Category:       ports
>Synopsis:       [Patch] x11/xstroke Makefile error
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 14 14:30:10 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Seaman
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD happy-idiot-talk.infracaninophile.co.uk 4.8-STABLE FreeBSD 4.8-STABLE #16: Wed Jul 9 14:35:57 BST 2003 root at happy-idiot-talk.infracaninophile.co.uk:/usr/obj/usr/src/sys/HAPPY-IDIOT-TALK i386

>Description:

The last update to the x11/xstroke port Makefile has resulted in a
broken system that goes into an infinite loop attempting to generate
the value of the GETOPTDIR variable by:

    GETOPTDIR!=	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC

The command depends on the value of ${PORTSDIR}, but that appears to
be null at the crucial time, so make -V WRKSRC gets run again in the
same directory.  Etc. Ad nauseam.

Note this kills rebuilding INDEX and so affects rather more people
than just the people with x11/xstroke installed.

>How-To-Repeat:

% cd /usr/ports/x11/xstroke
% make
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
cd: can't cd to /devel/libgnugetopt
...

>Fix:

	

--- xstroke-Makefile.patch begins here ---
--- Makefile.bak	Mon Jul 14 22:03:51 2003
+++ Makefile	Mon Jul 14 22:14:00 2003
@@ -24,7 +24,7 @@
 CPPFLAGS=	-I${LOCALBASE}/include
 LDFLAGS=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 MAKE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
-GETOPTDIR!=	cd ${PORTSDIR}/devel/libgnugetopt; make -V WRKSRC
+GETOPTDIR!=	cd ${.CURDIR}/../../devel/libgnugetopt; make -V WRKSRC
 
 MAN1=	xstroke.1
 
--- xstroke-Makefile.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: