ports/60371: sysutils/LPRng port can really compile on FreeBSD 5.x

[Seva Gluschenko]

>Number:         60371
>Category:       ports
>Synopsis:       sysutils/LPRng port can really compile on FreeBSD 5.x
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 18 08:10:16 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Seva Gluschenko
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Yandex LLC
>Environment:
System: FreeBSD road.yandex.ru 5.1-CURRENT FreeBSD 5.1-CURRENT #10: Mon Dec 15 17:17:48 MSK 2003 gvs at road.yandex.ru:/local/usr/src/sys/i386/compile/ROAD i386


	
>Description:
	sysutils/LPRng port is marked as broken for FreeBSD > 5.01 though it
	can be fixed easily.
>How-To-Repeat:
	CVSup sysutils/LPRng port on your FreeBSD 5.x box and try make. Build
	will be interrupted with the reason "marked as broken: does not compile".
>Fix:
	The root of the problem lays in "log()" function which is present in
	FreeBSD > 5.0x and thus conflicts with the log() functions in packages.
	This can be easily adopted by patching packages to eliminate log() name.

	Appy patch below:

--- Makefile.orig	Thu Dec 18 19:04:44 2003
+++ Makefile	Thu Dec 18 19:04:55 2003
@@ -50,10 +50,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} >= 501000
-BROKEN=		"Does not compile"
-.endif
-
 pre-everything::
 	@${ECHO_MSG} "If you want to replace the default printing system with LPRng, use:"
 	@${ECHO_MSG} "  make PREFIX=/usr SYSCONFDIR=/etc clean all install"

	Now place the following patch as files/patch-lpf.c.diff into your sysutils/LPRng
	port:

--- src/common/lpf.c.orig	Wed Apr 16 03:37:42 2003
+++ src/common/lpf.c	Thu Dec 18 18:58:29 2003
@@ -188,7 +188,7 @@
 int crlf;	/* change lf to CRLF */
 
 void getargs( int argc, char *argv[], char *envp[] );
-void log( char *msg, ... );
+void lpf_log( char *msg, ... );
 void logerr( char *msg, ... );
 void logerr_die( char *msg, ... );
 void fatal( char *msg, ... );
@@ -312,9 +312,9 @@
 }
 
 #ifdef HAVE_STDARGS
-void log(char *msg, ...)
+void lpf_log(char *msg, ...)
 #else
-void log( va_alist ) va_dcl
+void lpf_log( va_alist ) va_dcl
 #endif
 {
 #ifndef HAVE_STDARGS

	The port will compile fine.
>Release-Note:
>Audit-Trail:
>Unformatted: