ports/60239: net/poptop: fix WITH_KERNPPP option

Allan Saddi allan at saddi.com
Sun Dec 14 21:30:25 UTC 2003


>Number:         60239
>Category:       ports
>Synopsis:       net/poptop: fix WITH_KERNPPP option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 14 13:30:18 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Allan Saddi
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
Saddi Enterprises
>Environment:
System: FreeBSD tranquility.saddi.net 4.9-RELEASE FreeBSD 4.9-RELEASE #0: Mon Dec 1 22:19:22 PST 2003 root at tranquility.saddi.net:/usr/obj/usr/src/sys/TRANQUILITY i386

>Description:
In the recent commit (rev 1.18) of poptop's ports Makefile, the sense of the
WITH_KERNPPP option was flipped. Now one has to specifiy WITH_KERNPPP=yes
to build poptop with user ppp support, which doesn't make much sense.

>How-To-Repeat:
Try building poptop port. During the configure phase, you will see that
by default, the selected ppp is "Standard" (kernel pppd).

>Fix:

diff -ru poptop/Makefile poptop.new/Makefile
--- poptop/Makefile	Sat Oct 18 11:22:42 2003
+++ poptop.new/Makefile	Sun Dec 14 13:16:56 2003
@@ -28,7 +28,7 @@
 MAN5=		pptpd.conf.5
 MAN8=		pptpd.8 pptpctrl.8
 
-.ifdef(WITH_KERNPPP)
+.if !defined(WITH_KERNPPP)
 CONFIGURE_ARGS+=	--with-bsdppp
 .endif
 
>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list