ports/60027: [MAINTAINER] databases/postgresql-libpq++: unbreak header file

[Palle Girgensohn]

>Number:         60027
>Category:       ports
>Synopsis:       [MAINTAINER] databases/postgresql-libpq++: unbreak header file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 07 15:00:16 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Palle Girgensohn
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
Ping Pong AB
>Environment:
System: FreeBSD palle.girgensohn.se 4.9-RELEASE FreeBSD 4.9-RELEASE #6: Tue Nov  4 22:56:29 CET
>Description:
DLLIMPORT is not defined anywhere, but is expected in
pgconnection.h. This breaks building stuff using this library, and at
least ports/dns/powerdns is marked broken for this reason.

libpq++ is not really updated much anymore, so I don't expect any new
releas really. I checked the web site, and there was a discussion
about this (not quite accurate, though, does not really apply to
postgresql-7.4):
<http://gborg.postgresql.org/project/libpqpp/bugs/bugupdate.php?410>

Pointed out by: Dirk Meyer <dirk.meyer at dinoex.sub.org>

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

remove BROKEN line in dns/powerdns/Makefile :

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/dns/powerdns/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	5 Dec 2003 21:22:18 -0000	1.19
+++ Makefile	7 Dec 2003 22:35:37 -0000
@@ -36,7 +36,6 @@
 .endif
 
 .if defined(WITH_POSTGRESQL_DRIVER) && !defined(WITHOUT_POSTGRESQL_DRIVER)
-BROKEN=		does not compile with postgresql 7.4
 LIB_DEPENDS=	pq[+][+].4:${PORTSDIR}/databases/postgresql-libpq++
 CONFIGURE_ARGS+=	--enable-pgsql
 CONFIGURE_MODULES+=	"gpgsql"

----------

And add this patch to databases/postgresql-libpq++, and don't forget
to cvs add the patch file

--- /dev/null	Sun Dec  7 23:36:20 2003
+++ files/patch-pgconnection_h	Sun Dec  7 23:37:22 2003
@@ -0,0 +1,13 @@
+--- pgconnection.h.orig Wed Nov 27 05:46:08 2002
++++ pgconnection.h      Sun Dec  7 23:15:54 2003
+@@ -21,6 +21,10 @@
+ #ifndef PGCONNECTION_H
+ #define PGCONNECTION_H
+ 
++#ifndef DLLIMPORT
++#define DLLIMPORT
++#endif
++
+ #ifdef HAVE_CXX_STRING_HEADER
+ #include <string>
+ #endif
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/postgresql-libpq++/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	3 Sep 2003 08:06:18 -0000	1.3
+++ Makefile	7 Dec 2003 22:38:31 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	libpq++
 PORTVERSION=	4.0
+PORTREVISION=	1
 CATEGORIES=	databases
 MASTER_SITES=	ftp://gborg.postgresql.org/pub/libpqpp/stable/
 PKGNAMEPREFIX=	postgresql-
>Release-Note:
>Audit-Trail:
>Unformatted: