ports/55721: "Checking if XXX already installed" does not work

[Dmitry Sivachenko]

>Number:         55721
>Category:       ports
>Synopsis:       "Checking if XXX already installed" does not work
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 20 02:40:11 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Sivachenko
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Demos-Internet
>Environment:
System: FreeBSD tear.demos.su 4.8-STABLE FreeBSD 4.8-STABLE #0: Tue Jul 22 10:49:22 MSD 2003 mitya at tear.demos.su:/usr/src/sys/compile/TEAR i386


bsd.port.mk rev 1.462

>Description:

Though $found_package variable is properly populated, it is checked for 
non-zero length ( -n "$${found_package}" ) in another shell process where it
does not exist.

>How-To-Repeat:

Install a port of your choice.  Increase PORTVERSION and try to install the
same port again.  It will be installed, instead of displaying expected warning.

>Fix:

--- bsd.port.mk.old	Tue Aug 19 10:20:01 2003
+++ bsd.port.mk	Tue Aug 19 10:20:31 2003
@@ -3040,8 +3040,8 @@
 								fi; \
 						fi; \
 				done; \
-		fi;
-		@if [ -d ${PKG_DBDIR}/${PKGNAME} -o -n "$${found_package}" ]; then \
+		fi; \
+		if [ -d ${PKG_DBDIR}/${PKGNAME} -o -n "$${found_package}" ]; then \
 				if [ -d ${PKG_DBDIR}/${PKGNAME} ]; then \
 						${ECHO_CMD} "===>   ${PKGNAME} is already installed"; \
 				else \
>Release-Note:
>Audit-Trail:
>Unformatted: