ports/55507: lang/php4 compiles with unexcpected libs

[dirk.meyer at dinoex.sub.org]

>Number:         55507
>Category:       ports
>Synopsis:       lang/php4 compiles with unexcpected libs
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 12 11:10:15 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Dirk Meyer
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
privat
>Environment:

	FreeBSD 4.8-STABLE, FreeBSD-5.1-STABLE

>Description:

	Building on a clean system,
	or with more than one lib installed.
	php4 gives a lot of unexpected results in
	dependency and linking.

>How-To-Repeat:

	default:

	$ make all-depends-list
/usr/ports/converters/libiconv
/usr/ports/devel/bison
/usr/ports/devel/gettext
/usr/ports/devel/libtool13
/usr/ports/devel/libtool14
/usr/ports/devel/m4
/usr/ports/textproc/expat2
/usr/ports/www/apache13

	xml and mysql are missing in this list

	$ make -V WITH_MYSQL     
(empty output)

	an more ...

>Fix:

	apply this patch:

	- set WITH_* flags from PHP4_OPTIONS.
	- make BATCH=yes workin again for non default options
	- removes ugly "ifmake describe"
	- new sub-obtions to force dependencies explicit:
	WITH_MYSQL3, WITH_MYSQL41
	WITH_OPENLDAP12, WITH_OPENLDAP21, WITH_OPENLDAP22
	WITH_OPENSSL_PORT, WITH_OPENSSL_BETA
	WITH_SNMP4,

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/php4/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile	2 Aug 2003 22:34:54 -0000	1.22
+++ Makefile	12 Aug 2003 17:50:56 -0000
@@ -186,8 +186,11 @@
 .for opt in ${PHP4_OPTIONS}
 .if !defined(WITHOUT_${opt})
 SEL_OPTIONS+=	${opt}
-.endif
 SCRIPTS_ENV+=	WITH_${opt}=ON
+.if !exists(${WRKDIR}/Makefile.inc)
+WITH_${opt}=yes
+.endif
+.endif
 .endfor
 
 SCRIPTS_ENV+=	SEL_OPTIONS="${SEL_OPTIONS}" \
@@ -196,11 +199,6 @@
 		CAT="${CAT}" \
 		SED="${SED}"
 
-.ifmake describe
-WITH_MYSQL=	yes
-WITH_XML=	yes
-.endif
-
 .if exists(${WRKDIR}/Makefile.inc)
 .include "${WRKDIR}/Makefile.inc"
 .endif
@@ -412,9 +410,9 @@
 .endif
 
 .if defined(WITH_MYSQL)
-.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so.10)
+.if exists(${LOCALBASE}/lib/mysql/libmysqlclient.so.10) || defined(WITH_MYSQL3)
 LIB_DEPENDS+=	mysqlclient.10:${PORTSDIR}/databases/mysql323-client
-.elif exists(${LOCALBASE}/lib/mysql/libmysqlclient.so.14)
+.elif exists(${LOCALBASE}/lib/mysql/libmysqlclient.so.14) || defined(WITH_MYSQL41)
 LIB_DEPENDS+=	mysqlclient.14:${PORTSDIR}/databases/mysql41-client
 .else
 LIB_DEPENDS+=	mysqlclient.12:${PORTSDIR}/databases/mysql40-client
@@ -433,10 +431,10 @@
 .endif
 
 .if defined(WITH_OPENLDAP)
-.if exists(${LOCALBASE}/lib/libldap.so.1)
+.if exists(${LOCALBASE}/lib/libldap.so.1) || defined(WITH_OPENLDAP12)
 LIB_DEPENDS+=	ldap.1:${PORTSDIR}/net/openldap12
-.elif exists(${LOCALBASE}/lib/libldap.la)
-.if exists(${LOCALBASE}/bin/ldapwhoami)
+.elif exists(${LOCALBASE}/lib/libldap.la) || defined(WITH_OPENLDAP22)
+.if exists(${LOCALBASE}/bin/ldapwhoami) || defined(WITH_OPENLDAP21)
 LIB_DEPENDS+=	ldap.2:${PORTSDIR}/net/openldap21
 .else
 LIB_DEPENDS+=	ldap.2:${PORTSDIR}/net/openldap20
@@ -448,9 +446,12 @@
 .endif
 
 .if defined(WITH_OPENSSL) || defined(WITH_OPENSSL_DEP)
-.if exists(${LOCALBASE}/lib/libcrypto.so.3)
+.if exists(${LOCALBASE}/lib/libcrypto.so.3) || defined(WITH_OPENSSL_PORT)
 OPENSSLBASE=	${LOCALBASE}
 LIB_DEPENDS+=	crypto.3:${PORTSDIR}/security/openssl
+.elif defined(WITH_OPENSSL_BETA)
+OPENSSLBASE=	${LOCALBASE}
+LIB_DEPENDS+=	crypto.4:${PORTSDIR}/security/openssl
 .else
 OPENSSLBASE=	/usr
 .endif
@@ -514,8 +515,8 @@
 CONFIGURE_ARGS+=--enable-shmop
 .endif
 
-.if defined(WITH_SNMP)
-.if exists(${LOCALBASE}/lib/libsnmp.so.4)
+.if defined(WITH_SNMP) || defined(WITH_SNMP4)
+.if exists(${LOCALBASE}/lib/libsnmp.so.4) || 
 LIB_DEPENDS+=	snmp.4:${PORTSDIR}/net/net-snmp4
 .else
 LIB_DEPENDS+=	netsnmp.5:${PORTSDIR}/net/net-snmp
>Release-Note:
>Audit-Trail:
>Unformatted: