[PATCH] Fix panic with pf fastroute

Kristof Provost kristof at sigsegv.be
Thu Mar 12 00:16:53 UTC 2015


On 2015-03-11 13:50:50 (+0100), Kristof Provost <kristof at sigsegv.be> wrote:
> On 2015-03-11 12:50:23 (+0300), Andrey V. Elsukov <bu7cher at yandex.ru> wrote:
> > It looks like there are some code paths that do a copy of original mbuf.
> > Are you sure this doesn't introduce mbuf leak?
> > 
> I'll check again in the morning when I'm less drunk and jet lagged, but
> I'm pretty confident this is correct.
> There are only two exit points from pf_route6(), this one only happens
> in case of FASTROUTE, not DUPTO (which is the one that duplicates).
> 
So, yes, the duplication is only done if r->rt == PF_DUPTO and the case
I fixed is r->rt == PF_FASTROUTE.

Regards,
Kristof


More information about the freebsd-pf mailing list