Please review & test this

Vlad GALU vladgalu at gmail.com
Thu Jun 9 21:12:08 GMT 2005


        As you may all know, the packet classifier in ALTQ is very
slow on large numbers of classes, because it stores them linearly, in
an array. I rewrote the way classes are stored, replacing the array
with a hash table. I tested [1] on a system with about 8000 classes
and noticed a remarkable performance difference (the system went from
almost unusable to nice & smooth). It breaks the ABI by adding an
extra TAILQ_ENTRY  member to the HFSC class structure, though. If
anyone reviews and tests it, I would be grateful.

[1] http://night.rdslink.ro/dudu/altq/altq_hfschash.diff

P.S. please keep in mind that I'm not exactly a black belt in kernel
programming, so glitches might exist. I would be most happy to hear
some suggestions.

-- 
If it's there, and you can see it, it's real.
If it's not there, and you can see it, it's virtual.
If it's there, and you can't see it, it's transparent.
If it's not there, and you can't see it, you erased it.


More information about the freebsd-pf mailing list