[pf4freebsd] Re: pfflowd port
Andrew Thompson
andy at fud.org.nz
Wed Sep 15 21:02:23 PDT 2004
On Tue, Feb 24, 2004 at 11:34:35AM +0900, Pyun YongHyeon wrote:
> On Tue, Feb 24, 2004 at 02:29:47PM +1300, Andrew Thompson wrote:
> > > On Tuesday 24 February 2004 01:15, Andrew Thompson wrote:
> > > > Hi all,
> > > >
> > > > I have created a port for pfflowd and thought i'd get feedback before
> > > > submitting a PR.
> > > >
> > > > It can be found @
> > > >
> > > > http://www.fud.org.nz/pfflowd-port.tar.gz
> > >
> >
> > It generated a gcc warning, as addr->sin_port is a uint16_t which cant
> > be negative or >65536. -Werror made this fatal.
> >
> How about this?
>
> parse_hostport(const char *s, struct sockaddr_in *addr)
> {
[snip]
Thanks Max and Pyun for your feedback. I have rolled another attempt,
and i'll send a PR if its ok.
http://www.fud.org.nz/pfflowd-port.tar.gz
The only thing I was unsure about was to use ${CP} or ${CAT} to copy the
pidfile.* into the working dir.
Andy
More information about the freebsd-pf
mailing list