[Bug 200236] [maintainer][patch] games/wesnoth: fix for some FreeBSD 10.1 builds

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200236

--- Comment #25 from John Marino <marino at FreeBSD.org> ---
"Being practical, OPSYS/OSVERSION checks are _always_ more complex and less
correct than compiler check."

It's equally correct.  It also doesn't require changing USES so I don't get its
considered more complex.   The outliers are FreeBSD 8 and 9.

In reality there should be a standard macro / USES for this, it's a fairly
common issue.

"It really is a boost issue, see comment #1. You won't catch this with
poudriere. (his fix is not correct. This is not problem in wesnoth but boost -
it build unusable library in presence of libiconv. Boost should be fixed
instead.)"

What changed?   Boost has been the same forever.  Wesnoth just reverted to what
it was.  the bsd_iconv thing is FreeBSD 11 only isn't it?

Are you saying when you build it in ports, there is a good chance that libiconv
is already installed for another reason and boost builds wrong outside of
poudriere?  

I think that's what you must mean.  I would think that would also be limited to
a -CURRENT.

-- 
You are receiving this mail because:
You are on the CC list for the bug.