Use of C99 extra long double math functions after r236148
Steve Kargl
sgk at troutmask.apl.washington.edu
Sun Aug 12 22:57:56 UTC 2012
On Wed, Jul 18, 2012 at 10:13:37AM +1000, Peter Jeremy wrote:
> On 2012-Jul-17 16:27:40 -0700, Steve Kargl <sgk at troutmask.apl.washington.edu> wrote:
> >I won't have time to go over the code in detail until
> >this weekend, but a quick peek showed some issues. The
> >first is style. Although fdlibm has a rather interest
> >coding style, new code should use KNF.
>
> I hope that was only the function declaration lines. I think
> the rest is KNF.
Comments were wrong, too.
> >I think you're missing a sign. Let z = x + i*y.
> >Then, i*z = i*x+i*i*y = -y + i*x, yielding
>
> Yes, I think you're right in both cases. I wasn't thinking clearly.
> (Something to automatically generate this sort of code would mean you
> only need to write it once).
>
> Try the attached (also at http://www.rulingia.com/~peter/catan.c ).
> And I'm aware it has UTF-8 in the comments. I can't quickly find
> anything on character sets in style(9) and would apppreciate a
> ruling on it.
I doubt style(9) says anything about UTF-8 as style(9) has been
around a long time.
Can you inline the code after your sig? It is easier to review
and comment on; otherwise, I have to save the attachment, open
it in a window, and copy-n-paste.
It amy also be prudent to start a new thread as this subthread
may get lost. The question is where. I'm not subscribed to
hackers and Bruce is not subscribed to current.
--
Steve
More information about the freebsd-numerics
mailing list