ims_merge in in_mcast.c

Hans Petter Selasky hps at selasky.org
Tue Oct 13 08:18:39 UTC 2020


On 2020-10-12 19:11, Dheeraj Kandula wrote:
> On line 987 and 991 shouldn't the index be 0 instead of 1.
> 
> i.e. ims->ims_st[0].ex -= n;
> and
> ims->ims_st[0].in -= n;
> 
> On a rollback, the entry at index 0 is incremented and the entry at index 1
> is decremented.
> 
> On a non-rollback merge, the entry at index 0 is decremented and the entry
> at index 1 is incremented.

Hi,

If you look at inm_commit() you see that [0] is overwritten by [1], so I 
believe the current code is correct. Same goes for both IPv4 and IPv6. 
Are you seeing an issue with multicast investigating this issue?

--HPS


More information about the freebsd-net mailing list