Bug: Newreno; Seems Memory leak in newreno_cb_init

[Tom Jones]

On Tue, May 08, 2018 at 05:14:49PM +0530, Harsh Jain wrote:
> Hi All,
> 
> We have observed memory leak with TCP network traffic in "newreno".
> 
> Output of vmstat -m
> 
>    in_mfilter     3     3K       -        3  1024
>      in_multi     4     1K       -        4  256
>   ip_moptions     6     1K       -        6  64,256
> encap_export_host     2     2K       -        2  1024
>  newreno data 394849273 6169520K       - 394849273  16
>     sctp_a_it     0     0K       -        5  16
>      sctp_vrf     1     1K       -        1  64
>      sctp_ifa     7     1K       -        7  128
>      sctp_ifn     4     1K       -        4  128
> 
> There is 1 malloc in "newreno_cb_init" whose pointer is not saved in any global structure to free the same.
> 
> Is this a BUG?


Hi Harsh,

Adding Lawrence in cc

It looks like it, running nc in a loop I can watch MemUse grow. 

I think this should address the leak

https://reviews.freebsd.org/D15358

- [tj]