[Differential] D9847: Try to extract the RFC1048 data from PXE

Fri Mar 3 06:53:11 UTC 2017

smh added inline comments.

INLINE COMMENTS

> pxe.c:296
> +
> +			if (dhcp_try_rfc1048(bootplayer.vendor.d, BOOTP_DHCPVEND)) {
> +				if (pxe_debug)

Didn't spot this before but does this need a more explicit test as this method returns and isn't not a book and it's not clear what's the -1 is meant to trigger and how it's dealt with here?

REVISION DETAIL
  https://reviews.freebsd.org/D9847

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #network, gnn, smh
Cc: smh