[Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth

[Ravi Pokala]

-----Original Message-----


From: Sepherosa Ziehau <sepherosa at gmail.com>
Date: 2016-01-10, Sunday at 00:31
To: Ravi Pokala <rpokala at mac.com>
Cc: "freebsd-net at freebsd.org" <freebsd-net at freebsd.org>
Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth

>On Fri, Jan 8, 2016 at 11:59 PM, Ravi Pokala <rpokala at mac.com> wrote:
>>
>>...
>>
>> Forgive me if I'm missing something obvious, but this patch doesn't actually change anything - rather than hard-coding 65535, you're using lc->lro_hiwat... which is hard-coded to 65535.
>>
>> Right?
>
>The value is intended to be changed by NIC drivers, see the code
>commented out by the HN_LRO_HIWAT here:
>https://reviews.freebsd.org/D4824

Cool. In that case, please mention the fact that it is currently unused when you submit the change. :-)

Thanks,

Ravi (rpokala@)

>Thanks,
>sephe