page fault in tcp_do_segment (r287759 suspected)

Adrian Chadd adrian.chadd at gmail.com
Wed Sep 23 15:40:34 UTC 2015


Yes, file a bug. :)


-a


On 23 September 2015 at 00:11, Andriy Gapon <avg at freebsd.org> wrote:
> On 22/09/2015 11:33, Andriy Gapon wrote:
>> That code actually looks like the following DTrace probe a few lines below:
>>
>> TCP_PROBE3(debug__input, tp, th, mtod(m, const char *));
>>
>> So, it seems like 'm' could be NULL here.
>> I see two places in tcp_do_segment() where m gets assigned with NULL followed by
>> goto drop.  If I had to guess then my guess would be that one of those code
>> paths was taken.
>> Since those NULL assignments were there for more than a year, then I would guess
>> that the addition of the probe is to blame:
>> https://svnweb.freebsd.org/base?view=revision&revision=287759
>
> Should I file a bug report about this?
> Does anyone has suggestion for a simple fix?
>
> --
> Andriy Gapon
> _______________________________________________
> freebsd-net at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe at freebsd.org"


More information about the freebsd-net mailing list