Broken gif configuration compatibity

Eugene Grosbein eugen at grosbein.net
Fri Nov 20 12:16:40 UTC 2015


Hi!

I've just upgraded my 9.3-STABLE system to 10.2-STABLE and found that
my gif-interfaces no longer have "inet" IP addresses after boot.
"tunnel" addresses are still assigned.

I've digged this and found small bug in the commint
https://svnweb.freebsd.org/base?view=revision&revision=253924
that broken this. It overrides ifconfig_${ifn} with tunnel settings
instead of adding them to this variable.

One-line trivial fix restores compatibility:

--- src/network.subr.orig	2015-11-19 16:53:25.509440000 +0700
+++ src/network.subr	2015-11-20 18:47:36.914275000 +0700
@@ -1330,7 +1330,7 @@
 			_list="$_list $ifn"
 		fi
 		tmpargs=$(get_if_var $ifn gifconfig_IF)
-		eval ifconfig_${ifn}=\"tunnel \$tmpargs\"
+		eval ifconfig_${ifn}=\"\$ifconfig_${ifn} tunnel \$tmpargs\"
 	done
 	if [ -n "${_list# }" ]; then
 		echo "Created clone interfaces: ${_list# }."


I've just filled PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204700
Please consider fixing this.

Eugene Grosbein


More information about the freebsd-net mailing list