[Bug 203422] mpd/ppoe not working with re(4) with revision 285177

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Nov 9 00:19:18 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203422

--- Comment #4 from commit-hook at freebsd.org ---
A commit references this bug:

Author: marius
Date: Mon Nov  9 00:19:04 UTC 2015
New revision: 290566
URL: https://svnweb.freebsd.org/changeset/base/290566

Log:
  - Although it doesn't make a whole lot of sense to enable RX and TX
    before their initial configuration is done, it turns out that r281337
    has the inverse effect on some older chips. Moreover, as with newer
    chips before, two chips seemingly identical according to their MAC
    revisions may behave differently in this regard, with most working
    but a few not, making changes extremely hard to test.
    Closer inspection of the corresponding Linux code suggests that RX
    and TX should only be enabled after their initial configuration with
    RTL8168G and later chips, i. e. RTL8106E{,US}, RTL8107E, as well as
    RTL8168{EP,G,GU,H}, so limit the new code path to these. [1]
  - Distinguish between RTL8168H and RTL8107E, with the latter being the
    10/100-Mbit/s-only variant of the former.
  - For MAC variants that can only do Fast Ethernet at a maximum, ensure
    that we don't advertise Gigabit Ethernet speed.
  - In re_stop(), do the inverse of re_init_locked() and enable RXDV
    gate on RTL8168G and later chips again, matching what Linux does.

  PR:        203422 [1]
  MFC after:    1 week

Changes:
  head/sys/dev/re/if_re.c
  head/sys/dev/rl/if_rlreg.h

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-net mailing list