bce(4) panics, 9.2rc1, IPMI related?

[Sean Bruno]

> > 
> > bce0: <Broadcom NetXtreme II BCM5716 1000Base-T (C0)> mem
> > 0xda000000-0xdbffffff irq 36 at device 0.0 on pci1
> > miibus0: <MII bus> on bce0
> > brgphy0: <BCM5709 10/100/1000baseT PHY> PHY 1 on miibus0
> > brgphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT,
> > 1000baseT-master, 1000baseT-FDX, 1000baseT-FDX-master, auto, auto-flow
> > bce0: Ethernet address: d4:ae:52:8d:42:fc
> > bce0: ASIC (0x57092008); Rev (C0); Bus (PCIe x4, 2.5Gbps); B/C (5.2.3);
> > Bufs (RX:2;TX:2;PG:8); Flags (SPLT|MSI|MFW); MFW (NCSI 2.0.11)
> > Coal (RX:6,6,18,18; TX:20,20,80,80)
> > bce1: <Broadcom NetXtreme II BCM5716 1000Base-T (C0)> mem
> > 0xdc000000-0xddffffff irq 48 at device 0.1 on pci1
> > miibus1: <MII bus> on bce1
> > brgphy1: <BCM5709 10/100/1000baseT PHY> PHY 1 on miibus1
> > brgphy1:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, 1000baseT,
> > 1000baseT-master, 1000baseT-FDX, 1000baseT-FDX-master, auto, auto-flow
> > bce1: Ethernet address: d4:ae:52:8d:42:fd
> > bce1: ASIC (0x57092008); Rev (C0); Bus (PCIe x4, 2.5Gbps); B/C (5.2.3);
> > Bufs (RX:2;TX:2;PG:8); Flags (SPLT|MSI|MFW); MFW (NCSI 2.0.11)
> > Coal (RX:6,6,18,18; TX:20,20,80,80)
> > 
> 
There was no change reverting r253128.  I don't think that this affects
what I'm seeing.  However ... see below

> 
> These machines are using IPMI for management (Dell R410) and seem to be
> unable to attach to /dev/ipmi0:
> 
> ipmi0: <IPMI System Interface> port 0xca8,0xcac on acpi0
> ipmi0: KCS mode found at io 0xca8 on acpi
> ....
> ipmi1: <IPMI System Interface> on isa0
> device_attach: ipmi1 attach returned 16
> ipmi1: <IPMI System Interface> on isa0
> device_attach: ipmi1 attach returned 16
> ...
> ipmi0: Timed out waiting for GET_DEVICE_ID
> 
> 
> Sean
> 
tl;dr need a review of http://people.freebsd.org/~sbruno/ipmi_fixes.txt

I don't understand why, but ipmi_isa.c attach isn't seeing that
ipmi_acpi.c is attached at all.  Moreover, it takes slightly more that 3
seconds for the BMC on a Dell R410 to respond to GET_DEVICE_ID while
using the SOL console at 9600.  :-(

So, I've adjusted ipmivars.h::MAX_TIMEOUT to be (6 * hz) to properly
attach to ipmi0.

I've also done something gross, but I can't really see any way around
it.  I've added detection to ipmi_isa.c to see if the acpi IPMI
interface is enabled/disabled via "acpi_disabled" which means I have to
include ACPI header files in acpi_isa.c ... amusing, but it seems to
work.  I've been able to return the IPMI controller to the same behavior
that it appears to have in stable/7 now with the attached patch.

---
ipmi0: <IPMI System Interface> port 0xca8,0xcac on acpi0
ipmi0: KCS mode found at io 0xca8 on acpi
ipmi0: IPMI device rev. 0, firmware rev. 1.90, version 2.0
ipmi0: Number of channels 5
ipmi0: Attached watchdog
---

It looks like our implementation of IPMI somehow tries to attach TWICE
to the IPMI controller, once via ACPI and once via ISA.  This is really
confusing the hell out of the Broadcom management firmware even though
the second attachment fails.

Sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20130726/aecbd40c/attachment.sig>