[PATCH] Don't imply TCP and UDP socket options are bitmasks

John Baldwin jhb at freebsd.org
Mon Jan 14 21:58:00 UTC 2013


On Monday, January 14, 2013 4:42:16 pm Alfred Perlstein wrote:
> Wouldn't a comment over the code suffice?
> 
> Something like your email as a header would actually work very nicely!
> 
> I think just using decimal would be more confusing than explicitly 
> calling it out like:
> 
> /* begin enumerated (not bitmask) socket option specifiers */
> #define	TCP_MAXSEG	0x02	/* set maximum segment size */
> #define TCP_NOPUSH	0x04	/* don't push last block of write */
> #define TCP_NOOPT	0x08	/* don't use TCP options */
> #define TCP_MD5SIG	0x10	/* use MD5 digests (RFC2385) */
> /* end enumerated socket option specifiers */

I have a patch I'll post next which will add a new option as '3'.  I think that
will make it more obvious and avoid having new options follow the old pattern.

-- 
John Baldwin


More information about the freebsd-net mailing list