A small fix for if_em.c, if_igb.c, if_ixgbe.c

John Baldwin jhb at freebsd.org
Fri Dec 13 20:57:46 UTC 2013


On Monday, December 09, 2013 2:37:08 pm Adrian Chadd wrote:
> Jack / John - thoughts?

Note that if_start has always worked the way if_transmit would work with the 
err = 0 change.  All the other drivers in the tree are already giving you an 
error if an earlier packet in the IFQ fails to transmit, and it's been that 
way for decades.  If you decide to make if_transmit precise (only return an 
error if the specific packet fails), the corresponding change for if_start() 
drivers would be to never return an error ever.

It's not clear to me what the impact of that would be.  However, the current 
patch to return 0 in the drbr_putback case would at least restore things to 
the previous status quo from the past few decades for both if_start() and 
if_transmit() drivers.

-- 
John Baldwin


More information about the freebsd-net mailing list