CFR: FIB handling improvements

Andrey V. Elsukov bu7cher at yandex.ru
Thu Aug 22 13:29:03 UTC 2013


 21.08.2013 19:42, Will Andrews wrote:
> Hi,
> 
> I'm working to port forward to FreeBSD/head, improvements made to FIB
> handling by my colleagues Alan Somers and Justin Gibbs.
> 
> Please review: http://people.freebsd.org/~will/fix-fib-issues.1.diff
> 
> This patch includes fixes for several issues relating to FIBs:

Hi,

I also have a small patch.
Since icmp6_mtudisc_update() calls tcp_maxmtu6() where inc->inc_fibnum
is used, I think it is good idea to initialize this field.

-- 
WBR, Andrey V. Elsukov
-------------- next part --------------
Index: head/sys/netinet6/icmp6.c
===================================================================
--- head/sys/netinet6/icmp6.c	(revision 254653)
+++ head/sys/netinet6/icmp6.c	(working copy)
@@ -1227,6 +1227,7 @@ icmp6_mtudisc_update(struct ip6ctlparam *ip6cp, in
 		mtu = IPV6_MMTU - 8;
 
 	bzero(&inc, sizeof(inc));
+	inc.inc_fibnum = M_GETFIB(m);
 	inc.inc_flags |= INC_ISIPV6;
 	inc.inc6_faddr = *dst;
 	if (in6_setscope(&inc.inc6_faddr, m->m_pkthdr.rcvif, NULL))


More information about the freebsd-net mailing list