mwl(4) depends on non-existant mwlfw_fw (mwlfw doesn't implement mwlfw_fw)

[Bernhard Schmidt]

On Thursday, September 09, 2010 21:28:06 Christian Brueffer wrote:
> On Sun, Sep 05, 2010 at 07:11:59PM +0200, Bernhard Schmidt wrote:
> > On Sunday 05 September 2010 18:52:05 Bernhard Schmidt wrote:
> > > On Sunday 05 September 2010 17:53:08 Bruce Cran wrote:
> > > > Hi,
> > > > 
> > > > I was trying to help someone on IRC with a card that should be
> > > > supported by the mwl(4) driver, but it seems it's broken: mwlfw(4)
> > > > doesn't implement mwlfw_fw which if_mwl depends on
> > > > ("MODULE_DEPEND(mwl, mwlfw_fw, 1, 1, 1);").
> > > 
> > > This is wrong. It should depend on firmware(9), which also takes care
> > > of loading the adequate firmware modules.

I committed a fix for the firmware module dependencies. Thanks for pointing 
this out!

> > > > Should it be trying to load mw88W8363fw dynamically instead?
> > > 
> > > Yes, firmware(9) does that.
> > > 
> > > > The same error appears to be in malo(4) too - and neither mwlfw(4) or
> > > > malofw(4) are installed during an installkernel despite mwl(4) and
> > > > malo(4) being installed.
> > > 
> > > Seems like there is a MFC missing those get installed on HEAD.
> > 
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=144494
> 
> Oops, this fell through the cracks due to the missing MFC reminder
> trigger.  Fixed!

Thanks!

-- 
Bernhard